Skip to content

Conversation

@fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 25, 2025

PR description:

Add missing dependencies to DataFormats/SiPixelClusterSoA/BuildFile.xml.

PR validation:

Code builds.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 25, 2025

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 25, 2025

urgent

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 25, 2025

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 25, 2025

@cms-sw/orp-l2 sorry about this, I just run into the issue... can we have this in pre3 as well ?

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 25, 2025

+heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 25, 2025

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 25, 2025

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • DataFormats/SiPixelClusterSoA (heterogeneous, reconstruction)

@jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@VinInn, @dkotlins, @ferencek, @missirol, @mmusich, @mroguljic, @rovere, @tsusa this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b6460/49672/summary.html
COMMIT: 943301c
CMSSW: CMSSW_16_0_X_2025-11-25-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49471/49672/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 11 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4269665
  • DQMHistoTests: Total failures: 89
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4269556
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 248 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148187
  • DQMHistoTests: Total failures: 27256
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 120922
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 1 / 10 workflows

AMD_W7900 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 222 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148187
  • DQMHistoTests: Total failures: 36710
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 111471
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

NVIDIA_H100 Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 249 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148187
  • DQMHistoTests: Total failures: 27050
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 121131
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 1 / 10 workflows

NVIDIA_L40S Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 244 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148187
  • DQMHistoTests: Total failures: 27980
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 120199
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

NVIDIA_T4 Comparison Summary

Summary:

  • You potentially removed 16 lines from the logs
  • Reco comparison results: 258 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148187
  • DQMHistoTests: Total failures: 27499
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 120680
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 4 / 10 workflows

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6d71f4b into cms-sw:master Nov 26, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants