Open
Conversation
Signed-off-by: Robert Kielty <robert.kielty@cncf.io>
riaankleinhans
requested changes
Mar 1, 2024
Collaborator
riaankleinhans
left a comment
riaankleinhans
left a comment
There was a problem hiding this comment.
Some proposed grammar changes
tegioz
requested changes
Mar 4, 2024
Signed-off-by: Robert Kielty <robert.kielty@cncf.io>
Signed-off-by: Robert Kielty <robert.kielty@cncf.io>
Signed-off-by: Robert Kielty <robert.kielty@cncf.io>
Signed-off-by: Robert Kielty <robert.kielty@cncf.io>
tegioz
requested changes
Mar 5, 2024
| Note: the ```name: repo name``` does not necessarily appear as the first field in a repositories entry which can be confusing. | ||
| > [!IMPORTANT] | ||
| > | ||
| > - Invite users to join the CNCF Org *before you add them via a PR* to config.yaml |
Contributor
There was a problem hiding this comment.
Same as above. Actually, this doesn't apply to the repositories section, only to the teams top level section (please see sample in my other comment).
riaankleinhans
approved these changes
Mar 5, 2024
Collaborator
riaankleinhans
left a comment
riaankleinhans
left a comment
There was a problem hiding this comment.
Look good to me.
onlydole
reviewed
Mar 5, 2024
onlydole
suggested changes
Mar 5, 2024
Member
onlydole
left a comment
onlydole
left a comment
There was a problem hiding this comment.
Some minor nitpicks and suggestions.
README.md
Outdated
Comment on lines
+121
to
+123
| TODO Fix broken link here OR update this statement | ||
| Project names must exactly match [the landscape listing](https://landscape.cncf.io/card-mode?project=hosted). | ||
| TODO Are Category names missing? |
Member
There was a problem hiding this comment.
Should these be TODO comments, or is this section more of an FAQ or Troubleshooting section?
Co-authored-by: Taylor Dolezal <onlydole@users.noreply.github.com> Signed-off-by: Riaan Kleinhans <61125752+Riaankl@users.noreply.github.com>
Co-authored-by: Taylor Dolezal <onlydole@users.noreply.github.com> Signed-off-by: Riaan Kleinhans <61125752+Riaankl@users.noreply.github.com>
Signed-off-by: Robert Kielty <robert.kielty@cncf.io>
Signed-off-by: Robert Kielty <robert.kielty@cncf.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates README to
describe CLOWarden usage for the CNCF GitHub Org.
Removes references to Sheriff.
Swaps out a reference to an article on Medium on how to find your CNCF Slack ID for one provided by Slack docs.