Find a Generic way to fix flaky tests #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuonOmo
changed the base branch from
master
to
fix/test_create_with_query_cache
BuonOmo
force-pushed
the
fix/flaky-tests-method
branch
from
3d29a97 to
389161e
Compare
When using `--fail-fast` option the rails reporter could raise before other reporters records the failure. Hence we place rails last. Signed-off-by: Ulysse Buonomo <[email protected]>
BuonOmo
force-pushed
the
fix/flaky-tests-method
branch
13 times, most recently
from
da22db2 to
2827075
Compare
This test was failing due to missing a column in the model. We fix it by resetting the cache after adding the column. Signed-off-by: Ulysse Buonomo <[email protected]>
BuonOmo
force-pushed
the
fix/flaky-tests-method
branch
9 times, most recently
from
cb70966 to
dd3ac0c
Compare
Add `bin/minitest_bisect` to easily bisect with project configurations.
It was using old and invalid SQL statements. I took that opportunity to also change a bit its behaviour: - Remove the related rake task and automatically cache the schema if non-existent. - Cache every databases used in tests. - Ensure that cache name is based on schema files. - Rely on DefaultDB for db manipulations since the others might not exist.
Get one single table with every results from flaky tests.
BuonOmo
force-pushed
the
fix/flaky-tests-method
branch
from
dd3ac0c to
e061474
Compare
|
@rafiss I would merge that way since we are already fixing the most important flaky tests. And this workflow is the better compromise I found for now (running minitest_bisect in the CI isn't yet properly working). Since rails 8.1 is out, I'd rather merge this, and use it while coding for rails 8.1, and maybe open later a new pr if I find a better workflow. WDYT? |
rafiss
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new workflow
flaky.yml, I could see that there are quite a few flaky tests. However, fixing one with my current method is too slow. So This PR is a lab to find a better method. The main ideas for now are:NameError: uninitialized class variable @@already_loaded_fixturesNoMethodError: undefined method '<<' for nilActiveRecord::PreparedStatementCacheExpired: ERROR: cached plan must not change result typeActiveRecord::ConnectionTimeoutError: could not obtain a connection from the pool within 0.200 seconds (waited 0.200 seconds); all pooled connections were in useTimeout::Error: Test took over 5 minutes to finishActiveRecord::Encryption::EncryptableRecordTest#test_forced_encoding_for_deterministic_attributes_will_replace_invalid_charactersCockroachDB::TransactionsTest#test_concurrent_insert_with_processes:Minitest Bisect
Draft board for a GitHub Action based Bisect