changefeedccl: remove unnecessary redact.Safe calls #155289
Merged
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
This comment was marked as outdated.
This comment was marked as outdated.
|
This change is |
andyyang890
force-pushed
the
20251010-add-safe-string
branch
2 times, most recently
from
3381802 to
11dcf19
Compare
This patch removes two unnecessary `redact.Safe` calls where the origin of the data is within the changefeed packages and we know for sure that they're safe to not redact so we can notate at the origin that the data is safe instead of blanket unredacting at the destination. Release note: None
andyyang890
force-pushed
the
20251010-add-safe-string
branch
from
11dcf19 to
90296e4
Compare
KeithCh
approved these changes
Oct 15, 2025
asg0451
approved these changes
Oct 16, 2025
|
TFTRs! bors r=KeithCh,asg0451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes two unnecessary
redact.Safecalls where the originof the data is within the changefeed packages and we know for sure
that they're safe to not redact so we can notate at the origin that the
data is safe instead of blanket unredacting at the destination.
Epic: None
Release note: None