Skip to content

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Oct 16, 2025

Backport 1/1 commits from #155284 on behalf of @mw5h.


Add the 'bulkio.index_backfill.vector_merge_batch_size', which controls the number of rows to merge into vector indexes per transaction while the index is being created. This is analogous to the 'bulkio.index_backfill.merge_batch_size' setting, but it only applies when the target index is a vector index. By default, 3 vectors will be merged per transaction to reduce contention with fixup tasks.

Fixes: #155283
Release note (sql change): Added the
bulkio.index_backfill.vector_merge_batch_size cluster setting to control how many vectors to merge into a vector index per transaction during create operations. By default, this defaults to 3.


Release justification: This is needed for acceptable performance of a feature that is slated for 25.4 GA.

Add the 'bulkio.index_backfill.vector_merge_batch_size', which controls
the number of rows to merge into vector indexes per transaction while
the index is being created. This is analogous to the
'bulkio.index_backfill.merge_batch_size' setting, but it only applies
when the target index is a vector index. By default, 3 vectors will be
merged per transaction to reduce contention with fixup tasks.

Fixes: #155283
Release note (sql change): Added the
bulkio.index_backfill.vector_merge_batch_size cluster setting to control
how many vectors to merge into a vector index per transaction during
create operations. By default, this defaults to 3.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-25.4-155284 branch from 115e195 to 4691b07 Compare October 16, 2025 01:10
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 16, 2025
@blathers-crl blathers-crl bot requested review from DrewKimball and fqazi October 16, 2025 01:10
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 16, 2025

Thanks for opening a backport.

Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 16, 2025
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 16, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@michae2 michae2 requested review from michae2 and rafiss October 16, 2025 18:52
Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@michae2 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball, @fqazi, and @rafiss)

@mw5h mw5h merged commit c137260 into release-25.4 Oct 16, 2025
15 checks passed
@mw5h mw5h deleted the blathers/backport-release-25.4-155284 branch October 16, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. v25.4.0-prerelease

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants