[CC-33024] Remove the deprecated fields of CockroachDB operator #560
+183
−222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prafull01
force-pushed
the
remove-deprecated-fields
branch
3 times, most recently
from
13ac257 to
b01e115
Compare
prafull01
requested review from
NishanthNalluri and
pritesh-lahoti
and removed request for
pritesh-lahoti
| clusterSettings: ~ | ||
| # timestamp captures the annotation timestamp used for rolling restarts. | ||
| timestamp: "2021-10-18T00:00:00Z" | ||
| # resources captures the resource requests and limits for CockroachDB pods. |
There was a problem hiding this comment.
I believe we need to remove the whole resources section here.
build/templates/cockroachdb-parent/charts/cockroachdb/values.yaml
Outdated
Show resolved
Hide resolved
prafull01
force-pushed
the
remove-deprecated-fields
branch
2 times, most recently
from
0f4e15d to
1238344
Compare
prafull01
force-pushed
the
remove-deprecated-fields
branch
3 times, most recently
from
1238344 to
f886c28
Compare
pritesh-lahoti
approved these changes
Sep 30, 2025
| # If specified, podTemplate is merged with the default pod specification, with settings in podTemplate taking precedence. | ||
| # This can be used to add or update containers, volumes, and other settings of the CockroachDB pod. | ||
| podTemplate: {} | ||
| podTemplate: |
There was a problem hiding this comment.
nit: need to fix the indentation (of comments) within the podTemplate section.
prafull01
force-pushed
the
remove-deprecated-fields
branch
from
162b3a6 to
647a3a0
Compare
pritesh-lahoti
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
@prafull01 - as discussed, let's add a changelog entry for these changes and seek @jhlodin 's review for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.