-
Notifications
You must be signed in to change notification settings - Fork 16
version_deferral: add new policies for crdb patch deferral #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
91c2d40 to
947cf1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments. Please also update the CHANGELOG (under the ## [Unreleased] section) and run make generate to generate the docs changes
947cf1e to
bc6a383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, just left one question and a small suggestion
bc6a383 to
8d00bec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but I do have a question about using dedicated clusters (see test file for comment)
bfa3c44 to
361d018
Compare
Previously, there was only the FIXED_DEFERRAL policy allowing 60 days deferral. This PR adds new policy to defer the upgrades by 30,60 or 90 days. DEFERRAL_30_DAYS to defer upgrades by 30 days. DEFERRAL_60_DAYS to defer upgrades by 60 days. DEFERRAL_90_DAYS to defer upgrades by 90 days. NOT_DEFERRED to apply upgrades immediately.
361d018 to
c686018
Compare
Previously, there was only the FIXED_DEFERRAL policy allowing 60 days deferral.
This PR adds new policy to defer the upgrades by 30,60 or 90 days.
DEFERRAL_30_DAYS to defer upgrades by 30 days.
DEFERRAL_60_DAYS to defer upgrades by 60 days.
DEFERRAL_90_DAYS to defer upgrades by 90 days.
NOT_DEFERRED to apply upgrades immediately.
Commit checklist
make generate)