Skip to content

Conversation

@VishalJaishankar
Copy link
Contributor

@VishalJaishankar VishalJaishankar commented Oct 15, 2025

Previously, there was only the FIXED_DEFERRAL policy allowing 60 days deferral.

This PR adds new policy to defer the upgrades by 30,60 or 90 days.

DEFERRAL_30_DAYS to defer upgrades by 30 days.
DEFERRAL_60_DAYS to defer upgrades by 60 days.
DEFERRAL_90_DAYS to defer upgrades by 90 days.
NOT_DEFERRED to apply upgrades immediately.

Commit checklist

  • Changelog
  • Doc gen (make generate)
  • Integration test(s)
  • Acceptance test(s)
  • Example(s)

@VishalJaishankar VishalJaishankar force-pushed the vijaisha/flex-def branch 2 times, most recently from 91c2d40 to 947cf1e Compare October 17, 2025 05:56
@VishalJaishankar VishalJaishankar marked this pull request as ready for review October 17, 2025 06:06
@VishalJaishankar VishalJaishankar enabled auto-merge (rebase) October 17, 2025 06:07
@VishalJaishankar VishalJaishankar changed the title version_deferral: add new policy for crdb patch deferral version_deferral: add new policies for crdb patch deferral Oct 17, 2025
Copy link
Contributor

@linhcrl linhcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments. Please also update the CHANGELOG (under the ## [Unreleased] section) and run make generate to generate the docs changes

Copy link
Contributor

@linhcrl linhcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just left one question and a small suggestion

Copy link
Contributor

@linhcrl linhcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I do have a question about using dedicated clusters (see test file for comment)

@VishalJaishankar VishalJaishankar force-pushed the vijaisha/flex-def branch 2 times, most recently from bfa3c44 to 361d018 Compare October 23, 2025 09:38
Previously, there was only the FIXED_DEFERRAL policy allowing 60 days deferral.

This PR adds new policy to defer the upgrades by 30,60 or 90 days.

DEFERRAL_30_DAYS to defer upgrades by 30 days.
DEFERRAL_60_DAYS to defer upgrades by 60 days.
DEFERRAL_90_DAYS to defer upgrades by 90 days.
NOT_DEFERRED to apply upgrades immediately.
@VishalJaishankar VishalJaishankar merged commit 33acaab into main Oct 23, 2025
4 checks passed
@VishalJaishankar VishalJaishankar deleted the vijaisha/flex-def branch October 23, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants