add cockroach_blackout_window resource and cockroach_blackout_windows data source #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShashwatDash23
force-pushed
the
shashwatdash23/bow-resource
branch
3 times, most recently
from
480f3d3 to
56f9ba1
Compare
fantapop
reviewed
Oct 20, 2025
| ## Example Usage | ||
|
|
||
| ```terraform | ||
| # List all blackout windows (upto 100) |
There was a problem hiding this comment.
nit: Where does the number 100 come from here? It may be confusing for the user. Is this the default page size for the api?
There was a problem hiding this comment.
The number is defined here: https://github.com/cockroachlabs/managed-service/blob/master/pkg/serverutils/pagination.go#L27-L28. It’s the default page size used when no limit is set.
It’s applied here:: https://github.com/cockroachlabs/managed-service/blob/master/pkg/serverutils/pagination.go#L298C3-L302C112
Do you suggest that we should avoid mentioning the specific value (100) to users?
fantapop
approved these changes
Oct 20, 2025
… data source This commit adds support for blackout windows via the `cockroach_blackout_window` resource. It also adds a `cockroach_blackout_windows` data source for listing blackout windows.
ShashwatDash23
force-pushed
the
shashwatdash23/bow-resource
branch
from
56f9ba1 to
9e8465f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for blackout windows via the
cockroach_blackout_windowresource. It also adds acockroach_blackout_windowsdata source for listing blackout windows.Commit checklist
make generate)