Skip to content

bugfix: memory leak #20720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

bugfix: memory leak #20720

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b801115
bugfix: memory leak
niu2x Jan 22, 2022
002fad3
Merge branch 'cocos2d:v4' into v4
niu2x Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cocos/renderer/backend/opengl/CommandBufferGL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ void CommandBufferGL::setWinding(Winding winding)
void CommandBufferGL::setIndexBuffer(Buffer* buffer)
{
assert(buffer != nullptr);
if (buffer == nullptr)
if (buffer == nullptr || _indexBuffer == buffer)
return;

buffer->retain();
Expand All @@ -345,6 +345,7 @@ void CommandBufferGL::setVertexBuffer(Buffer* buffer)
return;

buffer->retain();
CC_SAFE_RELEASE(_vertexBuffer);
_vertexBuffer = static_cast<BufferGL*>(buffer);
}

Expand Down