BUGFIX: Fix .editorconfig#28
Open
alexander-nitsche wants to merge 6 commits intocode-q-web-factory:masterfrom
Open
BUGFIX: Fix .editorconfig#28alexander-nitsche wants to merge 6 commits intocode-q-web-factory:masterfrom
alexander-nitsche wants to merge 6 commits intocode-q-web-factory:masterfrom
Conversation
Author
|
What has also changed with the last commit is:
There are no JSON files in the skeleton, but there are Fusion files that would have to be reformatted if you keep this last commit. I checked it for the Neos Development Collection and indeed als Fusion and JSON files use the 2 spaces indentation. |
EditorConfig files are read from top to bottom and the last rules found have priority: The rules of package.json regarding indentation style and indentation size did not apply because they were overwritten by the following rules for "*.json".
These removed rules have already been defined as default.
Set 2 spaces as default indentation instead of 4.
alexander-nitsche
force-pushed
the
fix-editorconfig
branch
from
199133a to
21763b6
Compare
Author
|
Updated the author email address in all commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using your skeleton for my first Neos project, i (and PHPStorm) became aware of some inconsistencies in the .editorconfig. Some fixes are required, and some are nice to have. In the last commit i adapted it to the .editorconfig of the Neos Development Collection which uses a 2 spaces indentation by default instead of a 4 spaces. This reduces the set of rules, but maybe you still want to revert that last commit.