Skip to content

Conversation

@spalmurray
Copy link
Contributor

@spalmurray spalmurray commented Jul 8, 2025

More requirements for Mozilla.

image

@spalmurray spalmurray marked this pull request as ready for review July 8, 2025 17:46
@codecov
Copy link

codecov bot commented Jul 8, 2025

Bundle Report

Changes will increase total bundle size by 825 bytes (0.13%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
codecov-browser-extension-array-push 640.35kB 825 bytes (0.13%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: codecov-browser-extension-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
../consent.html 527 bytes 4.78kB 12.39% ⚠️
../consent.js 298 bytes 711 bytes 72.15% ⚠️

@spalmurray spalmurray changed the title Add data paragraph and uninstall button to consent page feat: Add data paragraph and uninstall button to consent page Jul 8, 2025
Copy link
Contributor

@ElioDiNino ElioDiNino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested locally and everything works as expected. Surely this time it will get approved 😅 🙏

@spalmurray
Copy link
Contributor Author

Surely!

@spalmurray spalmurray merged commit 9f645e8 into main Jul 8, 2025
3 checks passed
@spalmurray spalmurray deleted the spalmurray/consent-uninstall branch July 8, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants