feat: add pyi file for type hints in python #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the consuming python code will have to use `from __future__ import annotations` to use the type hints since these types aren't actually defined
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 96.95% 96.90% -0.06%
==========================================
Files 15 15
Lines 1871 1871
==========================================
- Hits 1814 1813 -1
- Misses 57 58 +1 ☔ View full report in Codecov by Sentry. |
Swatinem
approved these changes
Jan 9, 2025
Contributor
Swatinem
left a comment
Swatinem
left a comment
There was a problem hiding this comment.
wouldn’t the package also need a py.typed marker file as well to advertise that its typed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the consuming python code will have to use
from __future__ import annotationsto use the type hints since these types aren't actually defined