Skip to content

Conversation

@andy1li
Copy link
Member

@andy1li andy1li commented Nov 5, 2025

Issue

Currently, the setup echo commands treat "\n" as literal strings instead of newlines, when we wanted them to be interpreted as newlines.

Fix

Add '-e' flag to the echo commands.

image

Fixture

image

Note

Improve echo logging to correctly interpret newline escapes and update fixtures to match.

  • Core (logging/utils):
    • Enhance writeFiles to choose echo flags based on newline usage:
      • Trailing newline only → echo.
      • Newlines within content → echo -e (with trailing) or echo -ne (without trailing).
  • Fixtures:
    • Update internal/test_helpers/fixtures/{ash,bash}/pipelines/pass to reflect echo -e for multi-line setup writes.

Written by Cursor Bugbot for commit f354218. This will update automatically on new commits. Configure here.

@andy1li andy1li self-assigned this Nov 5, 2025
@andy1li andy1li added the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Triggered a Github Actions job to update fixtures.

@github-actions github-actions bot removed the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 5, 2025
@andy1li andy1li added the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Triggered a Github Actions job to update fixtures.

@github-actions github-actions bot removed the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 5, 2025
@andy1li andy1li requested a review from rohitpaulk November 5, 2025 02:04
@andy1li
Copy link
Member Author

andy1li commented Nov 5, 2025

Thanks to @feamcor for highlighting the issue!

@andy1li andy1li merged commit fe6a2b2 into main Nov 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants