Skip to content

Conversation

@andy1li
Copy link
Member

@andy1li andy1li commented Nov 6, 2025

Context:

https://forum.codecrafters.io/t/locate-executable-files/15494/10

User feedback:

I still don’t understand why when expected and received message is same it’s failed though

Issue:

qux/quz and bar/baz are easy to mix up:

image

Note

Replaces ambiguous small words and related tokens across utils and test fixtures, updating paths, commands, and expected outputs accordingly.

  • Core:
    • Update SMALL_WORDS in internal/utils.go from {"foo","bar","baz","qux","quz"} to {"ant","cat","cow","dog","fox","owl"}.
  • Test Fixtures (ash/bash):
    • Replace path/env tokens (e.g., foo/bar/baz/qux/quz) with distinct ones (e.g., ace/bar/qux/vix/doe) and adjust executable locations (my_exe, custom_exe_*).
    • Update invalid command names and echo text (fruit/word variants) across base, navigation, completions, pipelines, quoting, and redirection fixtures.
    • Tweak expected outputs for completions lists, pipeline/redirection file names and contents, and CWD string in pwd tests.
    • Add an extra invalid command check (invalid_command_5) in ff0 stages.
    • Refresh run_program_newline_in_args fixture to new PATH and expected output format.

Written by Cursor Bugbot for commit 70ea5b2. This will update automatically on new commits. Configure here.

@andy1li andy1li self-assigned this Nov 6, 2025
@andy1li andy1li added the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Triggered a Github Actions job to update fixtures.

@github-actions github-actions bot removed the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 6, 2025
@andy1li andy1li added the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Triggered a Github Actions job to update fixtures.

@github-actions github-actions bot removed the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Triggered a Github Actions job to update fixtures.

@andy1li andy1li added the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Triggered a Github Actions job to update fixtures.

@github-actions github-actions bot removed the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 6, 2025
@andy1li andy1li requested a review from rohitpaulk November 6, 2025 15:37
)

var SMALL_WORDS = []string{"foo", "bar", "baz", "qux", "quz"}
var SMALL_WORDS = []string{"foo", "bar", "ace", "doe", "qux", "vix"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Suggested change
var SMALL_WORDS = []string{"foo", "bar", "ace", "doe", "qux", "vix"}
var SMALL_WORDS = []string{"fox", "owl", "cat", "dog", "cow", "ant"}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(or something similar - basically avoid gibberish and use english words)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitpaulk Shall I remove cat from the list? Could be confused with the command cat.

@andy1li andy1li added the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 11, 2025
@github-actions
Copy link

Triggered a Github Actions job to update fixtures.

@github-actions github-actions bot removed the regenerate-fixtures Trigger a CI job to regenerate fixtures label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants