-
Notifications
You must be signed in to change notification settings - Fork 5
Update SMALL_WORDS list in utils.go #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Triggered a Github Actions job to update fixtures. |
|
Triggered a Github Actions job to update fixtures. |
|
Triggered a Github Actions job to update fixtures. |
|
Triggered a Github Actions job to update fixtures. |
internal/utils.go
Outdated
| ) | ||
|
|
||
| var SMALL_WORDS = []string{"foo", "bar", "baz", "qux", "quz"} | ||
| var SMALL_WORDS = []string{"foo", "bar", "ace", "doe", "qux", "vix"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
| var SMALL_WORDS = []string{"foo", "bar", "ace", "doe", "qux", "vix"} | |
| var SMALL_WORDS = []string{"fox", "owl", "cat", "dog", "cow", "ant"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(or something similar - basically avoid gibberish and use english words)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitpaulk Shall I remove cat from the list? Could be confused with the command cat.
|
Triggered a Github Actions job to update fixtures. |
Context:
https://forum.codecrafters.io/t/locate-executable-files/15494/10
User feedback:
Issue:
qux/quzandbar/bazare easy to mix up:Note
Replaces ambiguous small words and related tokens across utils and test fixtures, updating paths, commands, and expected outputs accordingly.
SMALL_WORDSininternal/utils.gofrom{"foo","bar","baz","qux","quz"}to{"ant","cat","cow","dog","fox","owl"}.foo/bar/baz/qux/quz) with distinct ones (e.g.,ace/bar/qux/vix/doe) and adjust executable locations (my_exe,custom_exe_*).pwdtests.invalid_command_5) inff0stages.run_program_newline_in_argsfixture to new PATH and expected output format.Written by Cursor Bugbot for commit 70ea5b2. This will update automatically on new commits. Configure here.