This repository was archived by the owner on Oct 7, 2025. It is now read-only.
n10-Creating-new-role-for-administration #2350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 4, 2025 15:09
added 10 commits
March 5, 2025 15:53
gregharvey
suggested changes
Mar 12, 2025
| @@ -1,10 +1,11 @@ | |||
| --- | |||
| dependencies: | |||
| - role: aws/aws_provision_ec2_keypair | |||
Member
There was a problem hiding this comment.
Where are these commented out?
| @@ -0,0 +1,74 @@ | |||
| - name: Create stage on API gateway | |||
Member
There was a problem hiding this comment.
Full stop at the end of this task name.
| ansible.builtin.include_tasks: create_methods.yml | ||
| loop: "{{ aws_admin_tools.functions }}" | ||
|
|
||
| - name: Obtain all information for a single WAF |
Member
There was a problem hiding this comment.
Actually, lots of missing full stops. Let's make sure all task names start with a capital letter and end in a full stop. For tidiness. 🙂
| --rest-api-id "{{ _api_gate.id }}" | ||
| register: _api_res_list | ||
|
|
||
| - name: Setting prevoius command output into variable |
| --region "{{ _aws_region }}" | ||
| register: _api_resource | ||
|
|
||
| - name: Setting prevoius command output into variable |
| --output text | ||
| register: _acc_id | ||
|
|
||
| - name: Setting prevoius command output into variable |
Member
There was a problem hiding this comment.
Actually, looks like it's been copied and pasted lots of times...
| ansible.builtin.command: | ||
| cmd: terraform apply -auto-approve | ||
| chdir: "{{ _ce_provision_build_tmp_dir }}" | ||
| - name: allocate a new elastic IP inside a VPC |
Member
There was a problem hiding this comment.
Capital letter at start and full stop at end please.
| @@ -0,0 +1,118 @@ | |||
| --- | |||
gregharvey
reviewed
Mar 12, 2025
| ansible.builtin.set_fact: | ||
| _acc_id: "{{ _acc_id.stdout | from_json }}" | ||
|
|
||
| - name: List all API gateways. |
|
gregharvey
approved these changes
Mar 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.