refactor: implement development versions for CodeIgniter::CI_VERSION#9951
refactor: implement development versions for CodeIgniter::CI_VERSION#9951paulbalandan merged 5 commits intocodeigniter4:developfrom
CodeIgniter::CI_VERSION#9951Conversation
paulbalandan
force-pushed
the
dev-ci-version
branch
from
d911afe to
d16f3b0
Compare
|
There are skipped tests in auto-review and I think those come from here. Need to see the details first. |
|
You won't forget that there are two branches 4.7.1-dev and 4.8.0-dev |
|
Yep, that would be for a follow up PR. |
paulbalandan
force-pushed
the
dev-ci-version
branch
from
d16f3b0 to
7b87291
Compare
paulbalandan
force-pushed
the
dev-ci-version
branch
5 times, most recently
from
108c90f to
22bc027
Compare
paulbalandan
force-pushed
the
dev-ci-version
branch
from
22bc027 to
1b6ca6d
Compare
| ); | ||
|
|
||
| // cleanup added and modified files | ||
| exec('git restore .'); |
There was a problem hiding this comment.
@paulbalandan You forgot about the developers.
The command deletes uncommited changes in the local environment. I cleared 10 files after the test 😢
There was a problem hiding this comment.
Sorry about this. I was also stuck at why my files gets deleted when running auto review tests.
There was a problem hiding this comment.
I won't be able to come to my laptop until Friday. Will you be able to effect the changes? Sorry again.
There was a problem hiding this comment.
I do not know how to change this. What if I edited the changelog and the test got lost? Cancellation is not possible.
I restored the files via the IDE timeline.
There was a problem hiding this comment.
Do I need to issue a note about uncommitted changes or create a temporary commit and return after the test?
3 participants
Description
Implements #9946 (comment)
Checklist: