Add open-state markers for nested popover parents #2967
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoopyDev
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
neSpecc
reviewed
Dec 2, 2025
| protected override showNestedItems(item: PopoverItem): void { | ||
| if (this.nestedPopover !== null && this.nestedPopover !== undefined) { | ||
| return; | ||
| if (this.nestedPopoverTriggerItem === item) { |
Member
There was a problem hiding this comment.
please, add a jsdoc describing this statement
| this.nestedPopover.show(); | ||
| this.flipper?.deactivate(); | ||
|
|
||
| this.clearOpenedState(); |
Member
There was a problem hiding this comment.
Why it is called twice in this context?
Comment on lines
+293
to
+296
| if (triggerEl) { | ||
| triggerEl.dataset.itemOpened = 'true'; | ||
| triggerEl.setAttribute('aria-expanded', 'true'); | ||
| } |
| } | ||
|
|
||
| /** | ||
| * Clears open-state markers from all popover items |
Member
There was a problem hiding this comment.
JSDoc repeats function name. Please, describe why we need this method instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UX improvement here! 😅
This lets parent tune buttons retain their hover/tint while a child menu is open and clears it when the submenu closes or another submenu opens.
data-item-opened/aria-expandedwhen nested popovers open/close