Skip to content

Comments

feat(redis): do not update rate limit counters#146

Open
e11sy wants to merge 5 commits intomasterfrom
feat/do-not-update-limit-counters
Open

feat(redis): do not update rate limit counters#146
e11sy wants to merge 5 commits intomasterfrom
feat/do-not-update-limit-counters

Conversation

@e11sy
Copy link
Contributor

@e11sy e11sy commented Jan 24, 2026

Problem

In the collector part we don't really know whether event would be stored into the db or not (that leads to but related to sentry events)

bug desc

collector gets all of the envelopes from sentry, it treats them as events and increments rateLimit counter in redis, however this envelope after parsing in sentry worker could be of type log, session, transaction etc.

we do not know how to process this types of the events, so we just skip them and never show to user

but rateLimit counter and chart counter were incremented by that event — here user is confused, because he can see events on the chart, or user is facing rate limit exceeded response, but he sees empty project overview

Solution

In the collector rateLimit counter becomes read-only — so we update this counter in grouper where we can't skip event, and guarantee that it would be stored to the db

Chart counter and rate limit counter updates are moved from collector to grouper

@e11sy e11sy requested review from khaydarov and n0str as code owners January 24, 2026 17:28
@e11sy e11sy force-pushed the feat/do-not-update-limit-counters branch from 320c712 to 51b3aa8 Compare January 25, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant