Open
Conversation
320c712 to
51b3aa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the collector part we don't really know whether event would be stored into the db or not (that leads to but related to sentry events)
bug desc
collector gets all of the envelopes from sentry, it treats them as events and increments
rateLimitcounter in redis, however this envelope after parsing in sentry worker could be of typelog,session,transactionetc.we do not know how to process this types of the events, so we just skip them and never show to user
but
rateLimitcounter and chart counter were incremented by that event — here user is confused, because he can see events on the chart, or user is facing rate limit exceeded response, but he sees empty project overviewSolution
In the collector rateLimit counter becomes read-only — so we update this counter in grouper where we can't skip event, and guarantee that it would be stored to the db
Chart counter and rate limit counter updates are moved from collector to grouper