Skip to content

Support titleCase option when initializing #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support titleCase option when initializing #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6df7d9
Support titleCase option
jeromecovington Oct 24, 2023
e534fc5
Expand tests for titleCase
jeromecovington Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/ga4.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,11 @@ export class GA4 {
gtagOptions,
nonce,
testMode = false,
titleCase = true,
gtagUrl,
} = options;
this._testMode = testMode;
this._titleCase = titleCase;

if (!testMode) {
this._loadGA(this._currentMeasurementId, nonce, gtagUrl);
Expand Down Expand Up @@ -417,13 +419,13 @@ export class GA4 {
// Required Fields
const fieldObject = {
hitType: "event",
eventCategory: format(category),
eventAction: format(action),
eventCategory: format(category, this._titleCase),
eventAction: format(action, this._titleCase),
};

// Optional Fields
if (label) {
fieldObject.eventLabel = format(label);
fieldObject.eventLabel = format(label, this._titleCase);
}

if (typeof value !== "undefined") {
Expand Down
44 changes: 44 additions & 0 deletions src/ga4.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,50 @@ describe("GA4", () => {
expect(gtag).toHaveBeenCalledTimes(0);
});

it("initialize() with default titleCase true", () => {
// Given
const options = {};

// When
GA4.initialize(GA_MEASUREMENT_ID, options);
GA4.event({
action: "action_name",
category: "category_name",
label: "label_name",
});

// Then
expect(gtag).toHaveBeenNthCalledWith(1, "js", newDate);
expect(gtag).toHaveBeenNthCalledWith(2, "config", GA_MEASUREMENT_ID);
expect(gtag).toHaveBeenNthCalledWith(3, "event", "Action_name", {
"event_category": "Category_name",
"event_label": "Label_name",
});
});

it("initialize() with titleCase false", () => {
// Given
const options = {
titleCase: false,
};

// When
GA4.initialize(GA_MEASUREMENT_ID, options);
GA4.event({
action: "action_name",
category: "category_name",
label: "label_name",
});

// Then
expect(gtag).toHaveBeenNthCalledWith(1, "js", newDate);
expect(gtag).toHaveBeenNthCalledWith(2, "config", GA_MEASUREMENT_ID);
expect(gtag).toHaveBeenNthCalledWith(3, "event", "action_name", {
"event_category": "category_name",
"event_label": "label_name",
});
});

it("initialize() multiple products", () => {
// Given
const GA_MEASUREMENT_ID2 = "GA_MEASUREMENT_ID2";
Expand Down