Skip to content

Conversation

@zeriyoshi
Copy link
Contributor

  • use Debian Bookworm (12) to Trixie (13)
  • use Debian default clang toolchain
  • fix coverage report

Copilot AI review requested due to automatic review settings September 2, 2025 03:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the build environment from Debian Bookworm (12) to Trixie (13) and simplifies the toolchain setup by using the default Debian clang package instead of the LLVM repository, while also fixing coverage report generation.

  • Update base image from Debian Bookworm to Trixie
  • Replace LLVM repository clang-19 with default Debian clang package
  • Fix coverage report by adding ignore-errors format flag to lcov

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
Dockerfile Updates base image tag and simplifies clang installation by removing LLVM repository setup
.gitmodules Removes duplicate submodule entry and adds ignore=dirty option
.github/workflows/coverage.yaml Updates distro matrix and adds lcov error handling flag
.github/workflows/ci.yaml Updates distro matrix from bookworm to trixie

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 20 to 21
&& update-alternatives --install "/usr/bin/clang" clang "/usr/bin/clang-19" 100 \
&& update-alternatives --install "/usr/bin/clang++" clang++ "/usr/bin/clang++-19" 100; \
Copy link

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update-alternatives commands are still referencing clang-19 and clang++-19, but the installation was changed to use the generic 'clang' package. These should be updated to reference the actual clang binaries installed by the Debian package (likely /usr/bin/clang and /usr/bin/clang++).

Suggested change
&& update-alternatives --install "/usr/bin/clang" clang "/usr/bin/clang-19" 100 \
&& update-alternatives --install "/usr/bin/clang++" clang++ "/usr/bin/clang++-19" 100; \
&& update-alternatives --install "/usr/bin/clang" clang "/usr/bin/clang" 100 \
&& update-alternatives --install "/usr/bin/clang++" clang++ "/usr/bin/clang++" 100; \

Copilot uses AI. Check for mistakes.
@zeriyoshi zeriyoshi self-assigned this Sep 2, 2025
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Code Metrics Report

main (c9ad9f1) #23 (60bf1a1) +/-
Coverage 84.0% 84.0% 0.0%
Details
  |           | main (c9ad9f1) | #23 (60bf1a1) | +/-  |
  |-----------|----------------|---------------|------|
  | Coverage  |          84.0% |         84.0% | 0.0% |
  |   Files   |              3 |             3 |    0 |
  |   Lines   |            477 |           477 |    0 |
  |   Covered |            401 |           401 |    0 |

Reported by octocov

@zeriyoshi zeriyoshi merged commit 37b6689 into main Sep 2, 2025
51 checks passed
@zeriyoshi zeriyoshi deleted the overhaul branch September 8, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants