-
Notifications
You must be signed in to change notification settings - Fork 3
Overhaul #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zeriyoshi
commented
Sep 2, 2025
- use Debian Bookworm (12) to Trixie (13)
- use Debian default clang toolchain
- fix coverage report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the build environment from Debian Bookworm (12) to Trixie (13) and simplifies the toolchain setup by using the default Debian clang package instead of the LLVM repository, while also fixing coverage report generation.
- Update base image from Debian Bookworm to Trixie
- Replace LLVM repository clang-19 with default Debian clang package
- Fix coverage report by adding ignore-errors format flag to lcov
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile | Updates base image tag and simplifies clang installation by removing LLVM repository setup |
| .gitmodules | Removes duplicate submodule entry and adds ignore=dirty option |
| .github/workflows/coverage.yaml | Updates distro matrix and adds lcov error handling flag |
| .github/workflows/ci.yaml | Updates distro matrix from bookworm to trixie |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| && update-alternatives --install "/usr/bin/clang" clang "/usr/bin/clang-19" 100 \ | ||
| && update-alternatives --install "/usr/bin/clang++" clang++ "/usr/bin/clang++-19" 100; \ |
Copilot
AI
Sep 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update-alternatives commands are still referencing clang-19 and clang++-19, but the installation was changed to use the generic 'clang' package. These should be updated to reference the actual clang binaries installed by the Debian package (likely /usr/bin/clang and /usr/bin/clang++).
| && update-alternatives --install "/usr/bin/clang" clang "/usr/bin/clang-19" 100 \ | |
| && update-alternatives --install "/usr/bin/clang++" clang++ "/usr/bin/clang++-19" 100; \ | |
| && update-alternatives --install "/usr/bin/clang" clang "/usr/bin/clang" 100 \ | |
| && update-alternatives --install "/usr/bin/clang++" clang++ "/usr/bin/clang++" 100; \ |
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Details | | main (c9ad9f1) | #23 (60bf1a1) | +/- |
|-----------|----------------|---------------|------|
| Coverage | 84.0% | 84.0% | 0.0% |
| Files | 3 | 3 | 0 |
| Lines | 477 | 477 | 0 |
| Covered | 401 | 401 | 0 |Reported by octocov |