Skip to content

Pretty print artifact on publishing #5528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+37 −35
Open

Pretty print artifact on publishing #5528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbb66d6
Pretty print artifact on publishing
lolgab Jan 13, 2025
d05deac
Update tests and examples to new output
lolgab Jul 15, 2025
8e55658
Merge branch 'main' into pretty-print-artifact
lihaoyi Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/extending/plugins/1-writing-mill-plugins/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ compiling 1 Scala source...
> sed -i.bak 's/0.0.1/0.0.2/g' build.mill

> ./mill myplugin.publishLocal
Publishing Artifact(com.lihaoyi,myplugin_millSNAPSHOT_3,0.0.2) to ivy repo...
Publishing com.lihaoyi:myplugin_millSNAPSHOT_3:0.0.2 to ivy repo...

*/
// Mill plugins are JVM libraries like any other library written in Java or Scala. Thus they
Expand Down
6 changes: 3 additions & 3 deletions example/javalib/basic/6-realistic/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ Qux.value: 31337
...foo.FooTests.test ...

> ./mill __.publishLocal
Publishing Artifact(com.lihaoyi,foo,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,bar,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,qux,0.0.1) to ivy repo...
Publishing com.lihaoyi:foo:0.0.1 to ivy repo...
Publishing com.lihaoyi:bar:0.0.1 to ivy repo...
Publishing com.lihaoyi:qux:0.0.1 to ivy repo...
...

> ./mill show foo.assembly # mac/linux
Expand Down
2 changes: 1 addition & 1 deletion example/javalib/publishing/2-publish-module/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ object foo extends JavaModule, PublishModule {
/** Usage

> ./mill foo.publishLocal
Publishing Artifact(com.lihaoyi,foo,0.0.1) to ivy repo...
Publishing com.lihaoyi:foo:0.0.1 to ivy repo...

*/

Expand Down
2 changes: 1 addition & 1 deletion example/javalib/publishing/3-revapi/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ object bar extends JavaModule, RevapiModule {
/** Usage

> ./mill bar.publishLocal
Publishing Artifact(com.lihaoyi,bar,0.0.1) to ivy repo...
Publishing com.lihaoyi:bar:0.0.1 to ivy repo...

> cp dev/src/Visibility.java bar/src/Visibility.java

Expand Down
6 changes: 3 additions & 3 deletions example/kotlinlib/basic/6-realistic/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,9 @@ Qux.value: 31337
...foo.FooTests hello ...

> ./mill __.publishLocal
Publishing Artifact(com.lihaoyi,foo,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,bar,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,qux,0.0.1) to ivy repo...
Publishing com.lihaoyi:foo:0.0.1 to ivy repo...
Publishing com.lihaoyi:bar:0.0.1 to ivy repo...
Publishing com.lihaoyi:qux:0.0.1 to ivy repo...
...

> ./mill show foo.assembly # mac/linux
Expand Down
2 changes: 1 addition & 1 deletion example/kotlinlib/publishing/2-publish-module/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ object foo extends KotlinModule, PublishModule {
/** Usage

> ./mill foo.publishLocal
Publishing Artifact(com.lihaoyi,foo,0.0.1) to ivy repo...
Publishing com.lihaoyi:foo:0.0.1 to ivy repo...

*/

Expand Down
10 changes: 5 additions & 5 deletions example/scalalib/basic/6-realistic/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,11 @@ Qux.value: 31337
+ foo.FooTests.test ... <h1>hello</h1>

> ./mill __.publishLocal
Publishing Artifact(com.lihaoyi,foo_2.13,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,bar_2.13,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,foo_3,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,bar_3,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,qux,0.0.1) to ivy repo...
Publishing com.lihaoyifoo_2.13:0.0.1 to ivy repo...
Publishing com.lihaoyibar_2.13:0.0.1 to ivy repo...
Publishing com.lihaoyifoo_3:0.0.1 to ivy repo...
Publishing com.lihaoyibar_3:0.0.1 to ivy repo...
Publishing com.lihaoyiqux:0.0.1 to ivy repo...

> ./mill show foo[2.13.16].assembly # mac/linux
".../out/foo/2.13.16/assembly.dest/out.jar"
Expand Down
2 changes: 1 addition & 1 deletion example/scalalib/publishing/2-publish-module/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ object foo extends ScalaModule, PublishModule {
> ./mill foo.publishLocal # publish specific modules

> ./mill __.publishLocal # publish every eligible module
Publishing Artifact(com.lihaoyi,foo_3,0.0.1) to ivy repo...
Publishing com.lihaoyi:foo_3:0.0.1 to ivy repo...

*/

Expand Down
16 changes: 8 additions & 8 deletions example/scalalib/web/7-cross-version-platform-publishing/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ Qux.main: Set(<p>i</p>, <p>cow</p>, <p>me</p>)
+ qux.QuxTests.parseJsonGetKeys ... Set(i, cow, me)

> ./mill __.publishLocal
Publishing Artifact(com.lihaoyi,foo-bar_sjs1_2.13,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,foo-bar_2.13,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,foo-qux_sjs1_2.13,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,foo-qux_2.13,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,foo-bar_sjs1_3,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,foo-bar_3,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,foo-qux_sjs1_3,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,foo-qux_3,0.0.1) to ivy repo...
Publishing com.lihaoyi:foo-bar_sjs1_2.13:0.0.1 to ivy repo...
Publishing com.lihaoyi:foo-bar_2.13:0.0.1 to ivy repo...
Publishing com.lihaoyi:foo-qux_sjs1_2.13:0.0.1 to ivy repo...
Publishing com.lihaoyi:foo-qux_2.13:0.0.1 to ivy repo...
Publishing com.lihaoyi:foo-bar_sjs1_3:0.0.1 to ivy repo...
Publishing com.lihaoyi:foo-bar_3:0.0.1 to ivy repo...
Publishing com.lihaoyi:foo-qux_sjs1_3:0.0.1 to ivy repo...
Publishing com.lihaoyi:foo-qux_3:0.0.1 to ivy repo...

*/
16 changes: 8 additions & 8 deletions example/scalalib/web/8-cross-platform-version-publishing/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,13 @@ Qux.main: Set(<p>i</p>, <p>cow</p>, <p>me</p>)

> ./mill __.publishLocal
...
Publishing Artifact(com.lihaoyi,bar_sjs1_2.13,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,bar_2.13,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,qux_sjs1_2.13,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,qux_2.13,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,bar_sjs1_3,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,bar_3,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,qux_sjs1_3,0.0.1) to ivy repo...
Publishing Artifact(com.lihaoyi,qux_3,0.0.1) to ivy repo...
Publishing com.lihaoyi:bar_sjs1_2.13:0.0.1 to ivy repo...
Publishing com.lihaoyi:bar_2.13:0.0.1 to ivy repo...
Publishing com.lihaoyi:qux_sjs1_2.13:0.0.1 to ivy repo...
Publishing com.lihaoyi:qux_2.13:0.0.1 to ivy repo...
Publishing com.lihaoyi:bar_sjs1_3:0.0.1 to ivy repo...
Publishing com.lihaoyi:bar_3:0.0.1 to ivy repo...
Publishing com.lihaoyi:qux_sjs1_3:0.0.1 to ivy repo...
Publishing com.lihaoyi:qux_3:0.0.1 to ivy repo...

*/
2 changes: 1 addition & 1 deletion example/thirdparty/fansi/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ Starting process: node
...

> ./mill fansi.native[3.1.3].publishLocal
Publishing Artifact(com.lihaoyi,fansi_native0.4_3,1.3.3.7) to ivy repo...
Publishing com.lihaoyi:fansi_native0.4_3:1.3.3.7 to ivy repo...
...

*/
2 changes: 1 addition & 1 deletion integration/migrating/init/src/MillInitMavenTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ object MillInitMavenJansiTests extends BuildGenTestSuite {
val ivy2Repo = tester.baseWorkspacePath / "ivy2Local"
val publishLocalRes = eval(("publishLocal", "--localIvyRepo", ivy2Repo.toString))
assert(
publishLocalRes.err.contains("Publishing Artifact(org.fusesource.jansi,jansi,2.4.1)"),
publishLocalRes.err.contains("Publishing org.fusesource.jansi:jansi:2.4.1"),
publishLocalRes.isSuccess
)
}
Expand Down
4 changes: 3 additions & 1 deletion libs/javalib/src/mill/javalib/publish/LocalIvyPublisher.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ class LocalIvyPublisher(localIvyRepo: os.Path) {
artifact: Artifact,
contents: Map[os.SubPath, FileSetContents.Writable]
)(implicit ctx: TaskCtx.Log): Seq[os.Path] = {
ctx.log.info(s"Publishing ${artifact} to ivy repo ${localIvyRepo}")
ctx.log.info(
s"Publishing ${artifact.group}:${artifact.id}:${artifact.version} to ivy repo ${localIvyRepo}"
)
Comment on lines +42 to +44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we override Artifact.toString() instead?

val releaseDir = localIvyRepo / artifact.group / artifact.id / artifact.version
FileSetContents.writeTo(releaseDir, contents)
}
Expand Down
Loading