[WIP] Update zinc to 2.0.0-Mx (released for Scala 3) #5767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2.0.0-M7 has just been released. |
lefou
force-pushed
the
tr-update-zinc-2
branch
from
4976b44 to
0dfb6d4
Compare
|
Marking this ready for review, to see CI results. |
lefou
changed the title
lefou
commented
Sep 19, 2025
lefou
commented
Sep 19, 2025
| // lacks support for FFM on Mac ARM. That should be fixed soon, see oracle/graal#8113. | ||
| val nativeTerminal = mvn"io.github.alexarchambault.native-terminal:native-terminal-no-ffm:0.0.9.1" | ||
| val zinc = mvn"org.scala-sbt::zinc:1.10.8".withDottyCompat(scalaVersion) | ||
| val zinc = mvn"org.scala-sbt::zinc:2.0.0-M8" |
There was a problem hiding this comment.
@lihaoyi I have no idea why this change breaks the whole build. It must have something to do with our classloader isolation, since the same bump worked flawlessly on older Mill versions (pre 1.0.0-M2, IIRC). Maybe you have an idea or recognize the errors, since you did the classloader isolation refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.