scalapb-support-java-generation #5817
Conversation
arminsumo
force-pushed
the
scalapb-support-java-generation
branch
from
5e06bff to
4e8e912
Compare
|
|
||
| object TutorialWithScalaAndJavaGen extends TutorialBase { | ||
| object core extends TutorialModule { | ||
| override def scalaPBGenerators = Seq[Generator](ScalaGen, JavaGen) |
There was a problem hiding this comment.
Seems like we need to explicitly define the type of the Seq here, otherwise upickle can't find the implicit reader.
although having a single value in there seems to work fine...
There was a problem hiding this comment.
Does making Generator an enum fixes the issue?
|
@lefou could you help review this one? Thanks! |
| sealed trait Generator derives ReadWriter { | ||
| def generator: String | ||
| def supportsScalaPBOptions: Boolean | ||
| } | ||
| case object ScalaGen extends Generator { | ||
| override def generator: String = "--scala_out" | ||
| override def supportsScalaPBOptions: Boolean = true | ||
| } | ||
| case object JavaGen extends Generator { | ||
| override def generator: String = "--java_out" | ||
| override def supportsScalaPBOptions: Boolean = | ||
| false // Java options are specified directly in the proto file | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you define Generator in it's own file? It also needs some docs what supportsScalaPBOptions means. I'd prefer to name it supportsScalaPbOptions (small b).
Are there other generators we could support? Can we add an CustomGen to let the user define and use other generators?
|
|
||
| def scalaPBVersion: T[String] | ||
|
|
||
| def scalaPBGenerators: T[Seq[Generator]] = Seq[Generator](ScalaGen) |
There was a problem hiding this comment.
Can we have some docs here which answers: What is a generator? Which can be choosen from? What is the default?
|
|
||
| object TutorialWithScalaAndJavaGen extends TutorialBase { | ||
| object core extends TutorialModule { | ||
| override def scalaPBGenerators = Seq[Generator](ScalaGen, JavaGen) |
There was a problem hiding this comment.
Does making Generator an enum fixes the issue?
Extend the scalapb plugin to allow for generating scala, or java, or both.
Can probably be extended in the future to support arbitrary generators https://scalapb.github.io/docs/scalapbc/#loading-additional-generators-from-maven