Skip to content

Storing Custom-Plugin (Non-SCL) Resources #609

Open
stiliyan-v wants to merge 51 commits intomainfrom
feature/594_plugins-custom-resources
Open

Storing Custom-Plugin (Non-SCL) Resources #609
stiliyan-v wants to merge 51 commits intomainfrom
feature/594_plugins-custom-resources

Conversation

@stiliyan-v
Copy link
Copy Markdown

@stiliyan-v stiliyan-v commented Mar 16, 2026 •
edited
Loading

@stiliyan-v stiliyan-v requested a review from a team as a code owner March 16, 2026 10:03
@stiliyan-v stiliyan-v added the enhancement New feature or request label Mar 16, 2026
@stiliyan-v stiliyan-v force-pushed the feature/594_plugins-custom-resources branch 7 times, most recently from 3897c0b to d0bd21d Compare March 17, 2026 12:52
@berke-akkaya berke-akkaya force-pushed the feature/594_plugins-custom-resources branch from 7b6f2c8 to 9b6274a Compare March 18, 2026 12:51
clepski
clepski requested changes Mar 20, 2026
View reviewed changes
Comment thread api/plugins-custom-resources.yaml Outdated
Comment thread app/src/main/java/org/lfenergy/compas/scl/data/rest/v1/CompasPluginsResource.java
Comment thread app/src/main/java/org/lfenergy/compas/scl/data/rest/v1/CompasPluginsResource.java
Comment thread app/src/main/resources/application.properties Outdated
Comment thread app/src/main/java/org/lfenergy/compas/scl/data/service/CompasPluginsResourceService.java
@clepski
Copy link
Copy Markdown
Contributor

clepski commented Mar 20, 2026

This PR adds several new dependencies and ways of building APIs, like using panache for entities and how endpoints are build. I am not against changing things for the better, but this amount of change requires some discussion and approval of the community.

Let's take this to the next compas community meeting for discussion.

david-monichi
david-monichi reviewed Mar 23, 2026
View reviewed changes
Comment thread app/src/main/java/org/lfenergy/compas/scl/data/service/UploadRequest.java Outdated
// SPDX-License-Identifier: Apache-2.0
package org.lfenergy.compas.scl.data.service;

public record UploadRequest(
Copy link
Copy Markdown
Contributor

@david-monichi david-monichi Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auf dieser Ebene müsste der Namen falsch, sein. Was passiert wenn das nicht über einen Http-Request rein kommt?

Comment thread app/src/main/java/org/lfenergy/compas/scl/data/service/CompasPluginsResourceService.java
Comment thread app/src/main/resources/application.properties
Comment thread app/pom.xml
Comment thread repository-postgresql/pom.xml
Copy link
Copy Markdown
Contributor

@david-monichi david-monichi Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need the repository-postgresql package in case of using panache?

Copy link
Copy Markdown
Author

@stiliyan-v stiliyan-v Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We store our panache entity class in this package.

Copy link
Copy Markdown
Contributor

@david-monichi david-monichi Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panache entity classes are not postgresql related, needs to be moved to repository module

Copy link
Copy Markdown
Contributor

@david-monichi david-monichi Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stiliyan-v this one I mentioned right before

david-monichi
david-monichi reviewed Mar 27, 2026
View reviewed changes
Comment thread app/src/main/resources/application-dev-postgresql.properties
quarkus.datasource.password = ${POSTGRESQL_PASSWORD:compas}

# Hibernate ORM configuration (schema managed by Flyway)
quarkus.hibernate-orm.database.generation = none
Copy link
Copy Markdown
Contributor

@david-monichi david-monichi Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't this just been added to application.properties so that its valid for all profiles? Same for line 28:30?
Same for prod profile

Comment thread repository/src/main/java/org/lfenergy/compas/scl/data/model/PluginsCustomResource.java

@Entity
@Table(name = "plugins_custom_resource")
public class PluginsCustomResource extends PanacheEntityBase {
Copy link
Copy Markdown
Contributor

@david-monichi david-monichi Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this class really postgresql relevant? Basically with Panache we split up the Database implementation with the model. We might want to move this to sub-module repository.
Only "repository-postgresql/src/main/resources/org/lfenergy/compas/scl/data/repository/postgresql/db/migration/V1_7__create_plugins_custom_resource.sql" should be DB dependent.

@stiliyan-v stiliyan-v force-pushed the feature/594_plugins-custom-resources branch 2 times, most recently from e97f972 to 7526c0b Compare March 30, 2026 13:29
david-monichi and others added 11 commits March 30, 2026 15:32
@david-monichi @stiliyan-v
Smaller API cleanups
2c34280 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@david-monichi @stiliyan-v
fix: Fixed license
e6ab13f 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@david-monichi @stiliyan-v
fix: Added missing licensing file
ab8807a 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@berke-akkaya @stiliyan-v
feat: Add
3c7919c 
      Flyway migration for plugins_custom_resource table

Signed-off-by: Berke Akkaya <berke.akkaya@bearingpoint.com>
@stiliyan-v
feat: Added rest endpoints for 594_plugins_custom_resources
5a3b3aa 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
fix: Added license to CompasPluginsResource
6fd9a80 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
feat: Added PluginsCustomResource entity
f630819 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
fix: Added quarkus-jdbc-postgresql dependency
5491705 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
fix: Added hibernate processor config
6a589ab 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
fix: Modified all PluginsCustomResource fields to be public
0ffb4fd 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@berke-akkaya @stiliyan-v
feat: Added Hibernate ORM config and auth permissions for plugins end…
0635710 
…points

Signed-off-by: Berke Akkaya <berke.akkaya@bearingpoint.com>
stiliyan-v and others added 12 commits March 30, 2026 15:38
@stiliyan-v
fix: added api module with the sources generated from OpenAPI
2ae84ff 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
fix: moved PluginsCustomResource entity to repository module
02235d4 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
fix: added index dependency for repository-postgresql and hibernate o…
e282956 
…rm config in application.properties

Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
fix: added licenses for the generated files
75e7a13 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
fix: moved panache-next dependency to repository module
849b1fa 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
fix: added readme for quarkus hibernate with panache next
98d983a 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
fix: added licenses for the new readme files
c44fef6 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
removed image group properties
356f845 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@berke-akkaya @stiliyan-v
fix: typo in scope
a8869af 
Signed-off-by: Berke Akkaya <berke.akkaya@bearingpoint.com>
@berke-akkaya @stiliyan-v
fix: added relative path for parent
3f747d7 
Signed-off-by: Berke Akkaya <berke.akkaya@bearingpoint.com>
@stiliyan-v
fix: added new step in build-project.yml that installs parent POM
0192ac3 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
fix: removed new step in build-project.yml that installs parent POM
e0e4ccd 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v stiliyan-v force-pushed the feature/594_plugins-custom-resources branch from 7526c0b to e0e4ccd Compare March 30, 2026 13:42
@stiliyan-v
fix: version of api has been updated to 0.17.4
8c11713 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v
test: added unit tests for generated dtos
4413633 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v stiliyan-v force-pushed the feature/594_plugins-custom-resources branch from ba59dda to aee9622 Compare March 31, 2026 07:31
@stiliyan-v
fix: use inheritance for DataEntry and DataEntryWithContent
0afc97d 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v stiliyan-v force-pushed the feature/594_plugins-custom-resources branch from aee9622 to 0afc97d Compare March 31, 2026 08:40
david-monichi
david-monichi requested changes Apr 14, 2026
View reviewed changes
Comment thread .../compas/scl/data/repository/postgresql/db/migration/V1_7__create_plugins_custom_resource.sql
Copy link
Copy Markdown
Contributor

@david-monichi david-monichi Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be sure, this file is postgresql related, therefore here ok

david-monichi
david-monichi reviewed Apr 14, 2026
View reviewed changes
Comment thread api/src/main/java/org/lfenergy/compas/scl/data/rest/dto/DataEntry.java Outdated
import java.util.Date;
import java.util.UUID;
import jakarta.validation.constraints.*;
import jakarta.validation.Valid;
Copy link
Copy Markdown
Contributor

@david-monichi david-monichi Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stiliyan-v

@stiliyan-v
fix: remove unused import
4cae00c 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@stiliyan-v stiliyan-v closed this Apr 14, 2026
@stiliyan-v stiliyan-v reopened this Apr 14, 2026
david-monichi
david-monichi previously approved these changes Apr 15, 2026
View reviewed changes
@clepski
Copy link
Copy Markdown
Contributor

clepski commented Apr 15, 2026

@stiliyan-v Please fix the last high sonarqube issue https://sonarcloud.io/project/issues?impactSeverities=HIGH&sinceLeakPeriod=true&issueStatuses=OPEN%2CCONFIRMED&pullRequest=609&id=com-pas_compas-scl-data-service

Then we should be good to go

@stiliyan-v
fix: map common data entry fields in a dedicated method
490a76c 
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 15, 2026

Quality Gate Passed Quality Gate passed

Issues
20 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stiliyan-v stiliyan-v requested a review from clepski April 15, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clepski clepski clepski approved these changes

@david-monichi david-monichi david-monichi left review comments

Assignees

@berke-akkaya berke-akkaya

@stiliyan-v stiliyan-v

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend scl-data-service with custom plugins resources endpoints

4 participants

@stiliyan-v @clepski @david-monichi @berke-akkaya