Added function create_offset_polygons_with_holes_2
#35
Conversation
| return [Polygon(points.tolist()) for points in offset_polygons] | ||
|
|
||
|
|
||
| def create_offset_polygons_with_holes_2(points, holes, offset) -> list[Tuple[Polygon, list[Polygon]]]: |
There was a problem hiding this comment.
should have asked this before, but i guess _2 means "2D"? perhaps this should be mentioned in the docstrings...
There was a problem hiding this comment.
right, i've added it to the docstrings. I've use "_2" as the cgal functions are named like that as well
| Raises | ||
| ------ | ||
| ValueError | ||
| If the normal of the polygon is not [0, 0, 1]. |
There was a problem hiding this comment.
should it be a unit normal, or vertical up?
There was a problem hiding this comment.
should be vertical up, i've adjusted the docstrings
| ------ | ||
| ValueError | ||
| If the normal of the polygon is not [0, 0, 1]. | ||
| If the normal of a hole is not [0, 0, -1]. |
There was a problem hiding this comment.
should it be a unit normal, or vertical down?
|
|
||
| H = [] | ||
| for i, hole in enumerate(holes): | ||
| points = list(hole) |
| hole = np.asarray(points, dtype=np.float64) | ||
| H.append(hole) | ||
|
|
||
| offset = float(offset) |
There was a problem hiding this comment.
in any case, would do this at the beginning of the algorithm. process all input params (if necessary) at the start...
There was a problem hiding this comment.
you are right, it is not needed
Added function
create_offset_polygons_with_holes_2along with some code refactorings onstraight_skeleton_2.cpp.