SAM to RAM conversion time benchmark #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
Sep 11, 2025
benchmark/sam_to_ram_benchmark.cxx
Outdated
| FILE *original_stdout = stdout; | ||
| stdout = fopen("/dev/null", "w"); | ||
|
|
||
| auto ttree_start = std::chrono::high_resolution_clock::now(); |
There was a problem hiding this comment.
We should use the way google bench is supposed to do it. These should be new benchmarks and not stop/start clocks...
Signed-off-by: AdityaPandeyCN <[email protected]>
AdityaPandeyCN
force-pushed
the
develop
branch
from
0a8d0ed to
73956ba
Compare
vgvassilev
reviewed
Sep 12, 2025
| for (auto _ : state) { | ||
|
|
||
| FILE *original_stdout = stdout; | ||
| stdout = fopen("/dev/null", "w"); |
Author
There was a problem hiding this comment.
I have done changes.Please have a look.
Signed-off-by: AdityaPandeyCN <[email protected]>
Signed-off-by: AdityaPandeyCN <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies to benchmark the conversion time from SAM to RAM in both the formats ttree and RNTuple formats.