concurrencpp: add missing includes, drop old versions and support clang #28285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: concurrencpp/0.1.7
Changes
include-missing-headers.patch
which fixes [package] concurrencpp/0.1.7 : failed to build from source on windows11 #28252.chrono
andstring
headers were missing, and this was causing compilation issues in Windows. See error:The patch is an extraction of a proposed upstream PR that has not been merged.
concurrencpp
, when compiled withclang
, forcedlibcxx
to belibc++
. This requirement was dropped years ago upstream (see relevant issue), but the enforcement was never removed from the recipe. Modern versions of clang (>=14, we are using 18 by the time this PR is opened) natively support coroutines.I've locally tested both compilations with
clang
andlibstdc++
/libc++
, all working correctly:clang + libstdc++:
clang + libc++:
Fix #28252
Close #25119