[xlsxio] Limit to use minizip-ng 4.0.7 as requirement to avoid incompatibility #28528
+6
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: xlsxio/0.2.34
Motivation
When reviewing #28004 and testing the side effects of having
minizip-ng/mz_compatibility=True
, the package for xlsxio failed to be built using minizip/4.0.10:Full build log: xlsxio-0.2.34-linux-gcc11-static-minizipng.log
As minizip-ng is an optional dependency, it passed by the CI without warnings, but users are broken in case using it due version range not limiting to the proper version.
The minizip-ng 4.0.8 passed by a transformation, including replacing the
mz_compat.h
by a few headers likeminizip-ng/zip.h
Further details about that release can be found in their changelog: https://github.com/zlib-ng/minizip-ng/releases/tag/4.0.8
The specific commit that changed the minizip-ng behavior is zlib-ng/minizip-ng@7df56f7. The release 4.0.8 is a patch version, but it looks a breaking change anyway.
Details
This PR limits the xlsxio/0.2.34 to use minizip-ng only until 4.0.7, which is safe:
xlsxio-0.2.34-linux-gcc11-static-patched.log
I also removed the logic checking the minimal version, as we only have 0.2.34 available in the recipe.
However, doing a quick look at xlsxio/0.2.36 (not in CCI yet), it has already adapted to use newer releases of minizip-ng, which will result in further changes in the recipe.