-
-
Notifications
You must be signed in to change notification settings - Fork 3
[bot-automerge] gz-rendering v9.3.0 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bot-automerge] gz-rendering v9.3.0 #42
Conversation
…nda-forge-pinning 2025.07.25.22.53.01
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18164920433. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly conda-forge automerge bot! It appears that not all commits to this PR were made by the bot. Thus this PR is not being automatically merged. Please add the |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17216169634. Examine the logs at this URL for more detail. |
|
macOS error: probably due to update in compiler. |
|
I think that the problem here is a change in the libc++ , concretely in 19 version;
Line 235 in OgreUTFString seems to be triggering the error by a template expansion over dstring that uses a uint32. Not sure about the best patch here, I'm going to report it upstream. |
Updated conda build configuration to use clang 18.
|
Thanks a lot @j-rivero and @iche033 for the follow up on this! As it is possible to see in llvm/llvm-project@aeecef0, all the removed functions were inline, so I think it is safe to just keep using clang 18 for the time being, while keeping the generated binaries compatible with newer libcxx versions. However, I wonder if before gz-rendering10 (where we are going to have an ABI bump anyhow) could it make sense to backport https://github.com/gazebosim/gz-rendering/pull/1177/files and set the CMake option |
|
@conda-forge-admin please rerender |
That makes sense to me yes. The only problem I had with gazebosim/gz-rendering#1177 is that the ABI checker is complaining for the OFF default option, although I'm not sure that it is correct. In the Jetty bump to 10, I would say let's backport gazebosim/gz-rendering#1177 here and enable the option from the beginning as you suggest, even if the ABI checker is true about ABI problems in default OFF we always be using the ON version here so ABI is preserve. This has the risk that we discover some runtime problem with the lack of Overlay but I think that it is a risk that can take. In the next major (11) there will be no problem if the gazebosim/gz-rendering#1175 goes well. |
I think there was a missing assignment of a CMake variable, see gazebosim/gz-rendering#1177 (comment) and gazebosim/gz-rendering#1177 (comment) . |
|
@conda-forge-admin please rerender |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/16539347737 - please use this URL for debugging.