Skip to content

Conversation

@ffernandolima
Copy link
Contributor

  • Removed support for .NET 6 as it has reached the end of support;
  • Added support for .NET 9;
  • Set 'LangVersion' to 'latest'.

Added support for .NET 9;
Set 'LangVersion' to 'latest'.
@ffernandolima ffernandolima requested review from a team as code owners November 20, 2024 18:52
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ ffernandolima
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@ffernandolima ffernandolima force-pushed the dotnet-9-support branch 2 times, most recently from 0218744 to 552eb2a Compare November 27, 2024 17:53
@Havret
Copy link
Contributor

Havret commented Nov 29, 2024

Would it make sense to add support for a version of .NET that isn't LTS?

@ffernandolima
Copy link
Contributor Author

Would it make sense to add support for a version of .NET that isn't LTS?

@Havret, I agree with you to some extent, and I believe this is open for discussion. However, the primary objective of this PR is to remove .NET 6, as it has reached its end of support and should no longer be used in active development.

@ffernandolima ffernandolima force-pushed the dotnet-9-support branch 5 times, most recently from 92c0a63 to 8971a04 Compare December 7, 2024 15:10
@Im5tu
Copy link

Im5tu commented Dec 11, 2024

Would it make sense to add support for a version of .NET that isn't LTS?

@Havret, I agree with you to some extent, and I believe this is open for discussion. However, the primary objective of this PR is to remove .NET 6, as it has reached its end of support and should no longer be used in active development.

Could just do a multi-target so you always have current STS + LTS versions, ie: net8/net9.

@ffernandolima
Copy link
Contributor Author

Could just do a multi-target so you always have current STS + LTS versions, ie: net8/net9.

@Im5tu, that was exactly what I did through this PR. Projects released as Nuget packages support multi-target.

@ffernandolima ffernandolima force-pushed the dotnet-9-support branch 2 times, most recently from 5a515b0 to 063a323 Compare December 16, 2024 18:14
Added support for .NET 9;
Set 'LangVersion' to 'latest'.
@ffernandolima
Copy link
Contributor Author

Hi @anchitj @rayokota, would it be possible to get this PR reviewed? Do you guys see any problems related to .NET 8 and .NET 9 multi-targeting and the removal of .NET 6? I'd appreciate it to get your opinion/point of view here.

@lgcmotta
Copy link

lgcmotta commented Jan 21, 2025

Would it make sense to add support for a version of .NET that isn't LTS?

I think yes, it makes sense. Each yearly release, whether STS or LTS, includes valuable performance improvements, new features, and bug fixes. If you only upgrade every two years, you risk missing out on incremental enhancements. Another point is: that by updating more frequently, you typically face smaller, more manageable changes rather than a large, potentially disruptive jump.
Although you’re unlikely to encounter major breaking changes on the language or packages API, there could still be under-the-hood modifications that introduce subtle issues if you skip multiple versions.

Copilot AI review requested due to automatic review settings October 30, 2025 17:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the project to support .NET 9 while removing support for the end-of-life .NET 6 framework. The changes modernize the language version settings and update conditional compilation directives to accommodate the new framework.

  • Updated target frameworks from .NET 6 and .NET 8 to .NET 8 and .NET 9 across all projects
  • Updated LangVersion from specific versions (7.1, 7.3) to 'latest' for modernized C# features
  • Modified conditional compilation for NJsonSchema packages to support .NET 9

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.

File Description
Test projects Updated TargetFrameworks from net6.0;net8.0 to net8.0;net9.0
Source projects Updated framework targeting and package conditions for .NET 9 support
Example projects Migrated from net6.0 to net9.0 and updated LangVersion to latest
JsonWithReferences example Added conditional compilation for NJsonSchema compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants