Validate inputs in OAuthBearerSetToken
#2444
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces null checks for the required parameters of OAuthBearerSetToken to prevent a segmentation fault when invalid arguments are provided.
- Adds checks to ensure tokenValue and principalName are not null.
- Throws an ArgumentNullException if either parameter is null.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
8 tasks
Member
|
/sem-approve |
Member
|
/sem-approve |
Havret
suggested changes
May 7, 2025
Contributor
Havret
left a comment
Havret
left a comment
There was a problem hiding this comment.
It's would be nice to have a test for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The documentation for
OAuthBearerSetTokennotes thattokenValueandprincipalNameare required parameters but doesn't check them for null values. As seen in this issue, ifprincipalNameisnull, the underlying library call will segfault (and do so silently in a Docker/Kubernetes environment. To keep from segfaulting, we can simply check those values fornulland throw accordingly.Checklist
References
Issue: #2158
Test & Review
Open questions / Follow-ups