fix(plpgsql-deparser): indent all lines of multi-line statements#259
Merged
pyramation merged 1 commit intomainfrom Jan 3, 2026
Merged
fix(plpgsql-deparser): indent all lines of multi-line statements#259pyramation merged 1 commit intomainfrom
pyramation merged 1 commit intomainfrom
Conversation
Previously, the indent() function only indented the first line of text. This caused incorrect formatting for nested IF/WHILE/LOOP blocks where subsequent lines would not be properly indented. The fix uses text.replace(/\n/g, '\n' + indent) to ensure all lines are indented, matching the behavior of the SQL implementation in constructive-db.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(plpgsql-deparser): indent all lines of multi-line statements
Summary
Fixes a bug where the
indent()function only indented the first line of text, causing incorrect formatting for nested PL/pgSQL blocks (IF/WHILE/LOOP/CASE).Before (broken):
After (fixed):
The fix changes
indent + texttoindent + text.replace(/\n/g, '\n' + indent)to ensure all lines receive proper indentation.Review & Testing Checklist for Human
pnpm testinpackages/plpgsql-deparserto confirm all tests passTest plan: Run the test suite and visually inspect a few of the snapshot diffs to confirm
END IF,END LOOP,ELSE,ELSIFetc. are now at the correct indentation level relative to their opening statements.Notes
This fix aligns the TypeScript implementation with the SQL implementation in constructive-db, which uses the same
replace('\n', '\n' + prefix)pattern.Link to Devin run: https://app.devin.ai/sessions/db60cce6c0f9424dbd943d47b1a7e5fa
Requested by: Dan Lynch (@pyramation)