Use AND to combine different volume filter keys#28413
Open
simonbrauner wants to merge 1 commit intocontainers:mainfrom
Open
Use AND to combine different volume filter keys#28413simonbrauner wants to merge 1 commit intocontainers:mainfrom
simonbrauner wants to merge 1 commit intocontainers:mainfrom
Conversation
0450a9a to
be1b236
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Contributor
Author
|
OR is currently used, and by changing it to AND would make it consistent with Docker. |
1fc2319 to
9efd4d8
Compare
|
Cockpit tests failed for commit 9efd4d8. @martinpitt, @jelly, @mvollmer please check. |
f5f69e7 to
9e080c1
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
80ec8e2 to
afbea92
Compare
Member
|
Frankly this is making me regret ever merging |
54712bf to
f8b2d28
Compare
f8b2d28 to
3c3613f
Compare
Member
|
How does it behave with containers, images? Whatever we end up it must be consistent for all filtering. |
Fixes: containers#26786 Signed-off-by: Šimon Brauner <sbrauner@redhat.com>
3c3613f to
98abcdc
Compare
Contributor
Author
AND is also used for filters of different keys when filtering images, containers, and pods. |
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #26786
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?