Skip to content

fix(resolve-extends): add import attribute for JSON config files #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

fix(resolve-extends): add import attribute for JSON config files #4551

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe97e91
fix(resolve-extends): add import attribute for JSON config files
macieklamberski Sep 25, 2025
38aea4d
fix(resolve-extends): use require() for JSON files instead of import …
macieklamberski Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions @commitlint/resolve-extends/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,24 @@ import resolveFrom_ from "resolve-from";
import { validateConfig } from "@commitlint/config-validator";
import type { ParserPreset, UserConfig } from "@commitlint/types";

// Check if Node.js version supports 'with' syntax (22+)
// Node.js < 22 supports 'assert'
// Node.js >= 22 uses 'with' (assert was removed in 22)
const supportsWithSyntax = () => {
const [major] = process.version.replace("v", "").split(".").map(Number);
return major >= 22;
};

const dynamicImport = async <T>(id: string): Promise<T> => {
const imported = await import(
path.isAbsolute(id) ? pathToFileURL(id).toString() : id
);
const fileUrl = path.isAbsolute(id) ? pathToFileURL(id).toString() : id;
const isJsonFile = fileUrl.endsWith(".json");

const imported = isJsonFile
? supportsWithSyntax()
? await import(fileUrl, { with: { type: "json" } })
: await import(fileUrl, { assert: { type: "json" } })
: await import(fileUrl);

return ("default" in imported && imported.default) || imported;
};

Expand Down