Skip to content

Conversation

WatheqAlshowaiter
Copy link

translation now updated with latest changes

Copy link

@Aseem007-007 Aseem007-007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ث

@bcoe
Copy link
Member

bcoe commented Jan 17, 2025

@NAMEER242 could you help with this review, I believe you did the first pass at this translation?

@NAMEER242
Copy link
Contributor

@NAMEER242 could you help with this review, I believe you did the first pass at this translation?

Sure, I can help with the review. Before starting, can you confirm if it's okay to add links to external sites in the docs? This PR includes links like:

most of them are blog posts and tools relevant to the conventional-commits topic, and since I don't see these kinds of references in other translations I think they should not be in the official documentation.

@bcoe
Copy link
Member

bcoe commented May 5, 2025

@NAMEER242 agreed, I'm excited to expand conventional commits into additional languages, but don't think we should add extra links to just one translation (CC: @WatheqAlshowaiter).

We do, however, have an about page, where links can be submitted (separately from this PR):

https://www.conventionalcommits.org/en/about/

@Aseem007-007
Copy link

ث

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants