-
Notifications
You must be signed in to change notification settings - Fork 184
Add cosa supermin-run
#3747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add cosa supermin-run
#3747
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| dn=$(dirname "$0") | ||
| # shellcheck source=src/cmdlib.sh | ||
| . "${dn}"/cmdlib.sh | ||
|
|
||
| print_help() { | ||
| echo "Usage: cosa supermin-run [--cache|--snapshot] COMMAND [ARG...]" >&2 | ||
| } | ||
|
|
||
| if [ $# = 0 ]; then | ||
| print_help | ||
| exit 1 | ||
| fi | ||
|
|
||
| need_cache_dir=0 | ||
| case "$1" in | ||
| --cache) | ||
| shift | ||
| set -- runvm_with_cache -- "$@" | ||
| need_cache_dir=1 | ||
| ;; | ||
| --snapshot) | ||
| shift | ||
| set -- runvm_with_cache_snapshot on -- "$@" | ||
| need_cache_dir=1 | ||
| ;; | ||
| --*) | ||
| echo "unrecognized option: $1" | ||
| print_help | ||
| exit 1 | ||
| ;; | ||
| *) | ||
| set -- runvm -- "$@" | ||
| ;; | ||
| esac | ||
|
|
||
| # force caller to create tmp/ and possibly cache/ rather than surprisingly | ||
| # auto-create them | ||
| if [ ! -d tmp ]; then | ||
| echo 'Need tmp/ dir for supermin to work' >&2 | ||
| exit 1 | ||
| fi | ||
| if [ $need_cache_dir = 1 ] && [ ! -d cache ]; then | ||
| echo 'Need cache/ dir for caching' >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| workdir=$(pwd) | ||
| export workdir | ||
|
|
||
| "$@" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sometimes I just
rm -rf cache/to blow away things to get a clean slate. I'm guessing something else would create it somewhere else in the stack, but...could we just move this into the if statement below? if there is a cachedev and somehow the cache dir doesn't exist we'd surely want to create it, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, but the
cache/dir must already exist at that point if using a cache qcow2, since the qcow2 is located there, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. but sometimes we don't use the cache qcow and things use the directory anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I feel like whatever/whoever does
rm -rf cache/should ensure to recreate it. E.g. rpm-ostree today will error out trying to cache things there. But not against adding amkdir -p cachesomewhere incmdlib.shtoo.