Skip to content

Revert "cmdlib: workaround rofiles-fuse mounts leaking" #3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Revert "cmdlib: workaround rofiles-fuse mounts leaking" #3860

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7846d8d
Revert "cmdlib.sh: keep trying to remount after killall hack"
jlebon Sep 4, 2024
03313d7
Revert "cmdlib: workaround rofiles-fuse mounts leaking"
HuijingHei Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/cmdlib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,13 +759,8 @@ else
fi
echo \$rc > ${rc_file}
if [ -n "\${cachedev}" ]; then
# XXX: brutal workaround for https://github.com/coreos/coreos-assembler/issues/3848
killall rofiles-fuse || :
/sbin/fstrim -v ${workdir}/cache
while ! mount -o remount,ro ${workdir}/cache; do
echo "failed to remount cache ro; retrying..." |& tee /dev/virtio-ports/cosa-cmdout
sleep 1
done
mount -o remount,ro ${workdir}/cache
fsfreeze -f ${workdir}/cache
fsfreeze -u ${workdir}/cache
umount ${workdir}/cache
Expand Down
Loading