cmd-cloud-prune: Fix indent-level for builds.json and compare only builds data
#3865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Aug 28, 2024
For consistency, keep the json indent level to 4 and also, only compare the respective json's build data instead of the whole file since we do update the timestamp in the builds.json in save_builds_json. Also double-check the size of builds array is the same after modifying
gursewak1997
force-pushed
the
prune-tweaks
branch
from
b7b4a10 to
fcc13c5
Compare
jlebon
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, keep the json indent level to 4 and also, only compare the respective JSON's build data instead of the whole file since we do update the timestamp in the
builds.jsoninsave_builds_json.