aliyun: make image replication idempotent #3872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a history of failure copying images to other regions on aliyun. Upstream code that calls the CopyImage code more than once will get a DuplicateImage error when an image with the same name already exists. Let's check to see if the image name exists in the region before attempting to copy the image to the region and return early if it already exists.
marmijo
approved these changes
Sep 10, 2024
dustymabe
reviewed
Sep 11, 2024
| // return early if there is already an image with that tag | ||
| if len(images.Images.Image) > 0 { | ||
| plog.Infof("image with name %v in %v region already exists--skipping copy", dest_name, dest_region) | ||
| return images.Images.Image[0].ImageId, nil |
There was a problem hiding this comment.
i wonder if we should somehow respect wait_for_ready here too? I guess it's possible that the image pre-exists but isn't ready yet.
|
/cherrypick rhcos-4.17 rhcos-4.16 rhcos-4.15 rhcos-4.14 rhcos-4.13 rhcos-4.12 |
|
@mike-nguyen: new pull request created: #3874 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a history of failure copying images to other regions on aliyun. Upstream code that calls the CopyImage code more than once will get a DuplicateImage error when an image with the same name already exists. Let's check to see if the image name exists in the region before attempting to copy the image to the region and return early if it already exists.