mantle/platform/gcloud: fix confidential compute check #3876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In db803c3 we add support for ConfidentialType but we made it so that we always execute this code where we don't want to do that if the user didn't specify any ConfidentialType for GCP. The way the code is now we can't run any GCP tests on non confidential instances. ``` failed to create instance "kola-dd144aac7413f66c85e9": Does not support confidential type , should be: sev, sev_snp ```
This is to appease golangci-lint: ``` Error: SA1019: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (staticcheck) ``` According to https://pkg.go.dev/math/rand#Seed "If Seed is not called, the generator is seeded randomly at program startup." so I think it's safe to just drop it.
|
Overall LGTM, thanks for the fixing! Seems need to fix CI. |
HuijingHei
previously approved these changes
Sep 13, 2024
|
For the ci error: Can change |
|
Confirm the patch works with both normal and confidential vm. |
|
hey @HuijingHei thanks fo trying to fix this. It looks like in other code where we use coreos-assembler/mantle/platform/machine/do/cluster.go Lines 117 to 119 in c211431 |
dustymabe
force-pushed
the
dusty-kola-gcp-fix
branch
2 times, most recently
from
b1d2b59 to
fe8b2f1
Compare
To appease golangci-lint: ``` Error: SA1019: rand.Read has been deprecated since Go 1.20 because it shouldn't be used: For almost all use cases, [crypto/rand.Read] is more appropriate. ```
dustymabe
force-pushed
the
dusty-kola-gcp-fix
branch
from
fe8b2f1 to
8af0e65
Compare
jlebon
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In db803c3 we add support for ConfidentialType but we made it so that we always execute this code where we don't want to do that if the user didn't specify any ConfidentialType for GCP.
The way the code is now we can't run any GCP tests on non confidential instances.