cmd-build: only copy allowed files into final build dir #3937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over time we seem to have accumulated all sorts of crud in the build dir that were never meant to be uploaded: ``` $ aws s3 ls s3://.../$buildid/x86_64/ ... 2024-10-26 10:49:16 1027 cmd.sh 2024-10-26 10:49:15 540 image.json 2024-10-26 10:49:15 8436 manifest.json 2024-10-26 10:49:15 2267 platforms.json 2024-10-26 10:49:15 2621 platforms.json.all 2024-10-26 10:49:16 2 rc 2024-10-26 10:49:16 97896 runvm-console.txt ``` There are no secrets in there, but still we should be more conscious of what we upload and keep artifacts in public build dirs to strictly what we intend. Historically, `$tmp_builddir` was meant to be the staging area for the final contents of the build dir we would move into place and `$TMPDIR` was the truly temporary directory for that build. Over time, that distinction has been lost a bit and things that shouldn't have been placed there were. In the end, I think it's cleaner to instead operate on an allowlist of files we know belong in the build dir, so let's do that.
|
I'm guessing |
Yeah, exactly. We never did anything more with it so I just nuked it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over time we seem to have accumulated all sorts of crud in the build dir that were never meant to be uploaded:
There are no secrets in there, but still we should be more conscious of what we upload and keep artifacts in public build dirs to strictly what we intend.
Historically,
$tmp_builddirwas meant to be the staging area for the final contents of the build dir we would move into place and$TMPDIRwas the truly temporary directory for that build. Over time, that distinction has been lost a bit and things that shouldn't have been placed there were.In the end, I think it's cleaner to instead operate on an allowlist of files we know belong in the build dir, so let's do that.