fix: CIDR & AuditLogPartsValue syntax#94
Open
touchweb-vincent wants to merge 5 commits intocoreruleset:mainfrom
Open
fix: CIDR & AuditLogPartsValue syntax#94touchweb-vincent wants to merge 5 commits intocoreruleset:mainfrom
touchweb-vincent wants to merge 5 commits intocoreruleset:mainfrom
Conversation
touchweb-vincent
changed the title
touchweb-vincent
changed the title
Contributor
|
thanks for this contribution! Could you add some tests which provide that the parser works as we expect with the mentioned tokens? You can see existing test file for examples. Let us know if you need any help. |
fzipi
reviewed
Oct 30, 2025
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
Author
|
HI @airween I don’t have the level to fully understand what’s expected, and I don’t have time to catch up right now. I’ve written the rules to be tested - what remains is to complete the desired assertions. |
Member
|
@touchweb-vincent Can you rebase to latest main and move the tests to the new https://github.com/coreruleset/secrules_parsing/blob/main/tests/test_operators.py file? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a proposal to manage this correctly :
SecRule REMOTE_ADDR "!@ipMatch 145.226.0.0/24,2001:4860:4801:3c::/64" "chain"