Update multivariate_normal.py to use loc instead of mean #2488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update MultivariateNormal to better match torch.distributions.MultivariateNormal Also, add typing annotation that allows `loc` to be a LinearOperator
|
Thanks. I expect this to cause some backward compatibility problems though, e.g. here in BoTorch. Not sure if it's worth the trouble of changing this in a way that deprecates the old arg name, but that's something you could do if you feel strongly about the renaming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update MultivariateNormal to better match torch.distributions.MultivariateNormal
Also, add typing annotation that allows
locto be a LinearOperator