feat(solana): remove client_id and chain_id from PDA derivations #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed module names from hyphenated to underscore format - Updated ModuleSolanaToCosmos from "solana-to-cosmos" to "solana_to_cosmos" - Updated ModuleCosmosToSolana from "cosmos-to-solana" to "cosmos_to_solana" - Ensures consistency with other module naming conventions
Key additions: - Complete IBC flow: Add full send → relay → acknowledge pipeline for both send_transfer and send_packet - Bidirectional clients: WASM light client on Cosmos + Tendermint client on Solana - Token transfer validation: Verify IBC denom construction and minting on destination - Mock proof support: Enable testing with MockWasmClient flag Relayer fixes: - Fix encoding json → application/json for IBC compatibility - Proper hex decoding for transaction hashes (hex.DecodeString vs []byte) - Mock proof injection and protobuf transaction encoding Transaction size constraint: - Document Solana 1644-byte limit blocking acknowledgments (1892 bytes actual) - Skip oversized transactions with TODO for optimization Infrastructure: - Extract shared Solana utilities to solana/solana.go - Add SolDenom constant and getSolDenomOnCosmos() helper
mariuszzak
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/solana #715 +/- ##
==============================================
Coverage ? 99.86%
==============================================
Files ? 17
Lines ? 767
Branches ? 0
==============================================
Hits ? 766
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Base automatically changed from
mariuszzak/test-e2e-sol-to-cosmos
to
feat/solana
September 2, 2025 15:05
srdtrk
requested changes
Sep 9, 2025
Comment on lines
29
to
30
| PACKET_COMMITMENT_SEED, | ||
| msg.packet.source_client.as_bytes(), | ||
| &msg.packet.sequence.to_le_bytes() |
There was a problem hiding this comment.
I don't think you can do this is ics26 router
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
client_idandchain_idparameters from all Program Derived Address derivation functions and account constraints across Solana programs, relayer, and E2E tests.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.