feat(solana): implement ics27-gmp ibc app #757
+14,346
−967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/solana #757 +/- ##
==============================================
Coverage ? 99.86%
==============================================
Files ? 17
Lines ? 767
Branches ? 0
==============================================
Hits ? 766
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mariuszzak
force-pushed
the
mariuszzak/ics27-gmp
branch
from
dc6c040 to
b6f5bb3
Compare
|
Related PR - cosmos/ibc-go#8660 |
mariuszzak
force-pushed
the
mariuszzak/ics27-gmp
branch
from
b6f5bb3 to
e10d7bf
Compare
mariuszzak
force-pushed
the
mariuszzak/ics27-gmp
branch
3 times, most recently
from
97ebeed to
c8a763d
Compare
mariuszzak
changed the base branch from
mariuszzak/test-e2e-cosmos-to-sol
to
feat/solana
mariuszzak
force-pushed
the
mariuszzak/ics27-gmp
branch
8 times, most recently
from
d3ec90b to
dadce0c
Compare
mariuszzak
changed the title
mariuszzak
force-pushed
the
mariuszzak/ics27-gmp
branch
3 times, most recently
from
0d410ae to
9d10cf6
Compare
mariuszzak
commented
Oct 15, 2025
srdtrk
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
We should use the proto definition present in ibc-go for this. We have a seperate repo that generates rust code for proto definitions in ibc-go. This is something we can refactor later.
There was a problem hiding this comment.
@srdtrk could you create a task for this? 🙏
programs/solana/programs/ics27-gmp/src/instructions/on_ack_packet.rs
Outdated
Show resolved
Hide resolved
programs/solana/programs/ics27-gmp/src/instructions/on_recv_packet.rs
Outdated
Show resolved
Hide resolved
programs/solana/programs/ics27-gmp/src/instructions/on_timeout_packet.rs
Outdated
Show resolved
Hide resolved
programs/solana/programs/ics27-gmp/src/instructions/on_timeout_packet.rs
Outdated
Show resolved
Hide resolved
vaporif
reviewed
Oct 17, 2025
vaporif
reviewed
Oct 17, 2025
vaporif
reviewed
Oct 17, 2025
vaporif
reviewed
Oct 17, 2025
programs/solana/programs/ics27-gmp/src/instructions/on_ack_packet.rs
Outdated
Show resolved
Hide resolved
vaporif
reviewed
Oct 17, 2025
programs/solana/programs/ics27-gmp/src/instructions/on_ack_packet.rs
Outdated
Show resolved
Hide resolved
vaporif
reviewed
Oct 17, 2025
programs/solana/programs/ics27-gmp/src/instructions/on_timeout_packet.rs
Outdated
Show resolved
Hide resolved
vaporif
reviewed
Oct 17, 2025
vaporif
reviewed
Oct 17, 2025
vaporif
reviewed
Oct 17, 2025
vaporif
reviewed
Oct 17, 2025
vaporif
reviewed
Oct 17, 2025
mariuszzak
force-pushed
the
mariuszzak/ics27-gmp
branch
2 times, most recently
from
86071fc to
3cbee29
Compare
mariuszzak
force-pushed
the
mariuszzak/ics27-gmp
branch
from
3cbee29 to
22fb4a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements ICS27-GMP app. More details in the ADR added in this PR.
ref: IBCSOL-267
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.