CBL-7866: Exception when decode a cbllog binary file#2447
Open
jianminzhao wants to merge 1 commit intomasterfrom
Open
CBL-7866: Exception when decode a cbllog binary file#2447jianminzhao wants to merge 1 commit intomasterfrom
jianminzhao wants to merge 1 commit intomasterfrom
Conversation
The symptom points to possiblity that string contains '\0' in the content. This caused that we write bytes after 0, which the decoder thinks it ends a string, and leaving some bytes unconsumed. We fix it by getting c_str() from a string before we write the string, truncating all bytes after 0.
|
Code Coverage Results:
|
Collaborator
|
It should throw an exception instead of truncating the string. We need to find out how this could happen and fix that. |
Contributor
Author
|
If we throw, where to catch it? Do we close the encoder and roll to a new encoder? Usually, it happens in customer field, how would it get our attention? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symptom points to possiblity that string contains '\0' in the content. This caused that we write bytes after 0, which the decoder thinks it ends a string, and leaving some bytes unconsumed. We fix it by getting c_str() from a string before we write the string, truncating all bytes after 0.