feat: add downlaod-wheel.sh to release note #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
- Fix pipe character usage in shell commands within GitHub Actions expressions - Replace problematic expressions with proper shell variable substitution - Add proper error handling for tool installation step - Fix missing newline before platform override test step
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Python script to automatically download appropriate clang-format and clang-tidy wheels for the current platform, along with comprehensive testing infrastructure and documentation updates.
- Adds
download.pyscript with platform detection and automatic wheel downloading from GitHub releases - Creates comprehensive CI workflow to test the download script across multiple platforms and Python versions
- Updates documentation with quick install instructions and supported platform information
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| download.py | Main Python script that detects platform, fetches GitHub releases, and downloads appropriate wheels |
| README.md | Updated with quick install instructions using the download script and supported platforms table |
| .pre-commit-config.yaml | Added ruff linting and formatting to maintain code quality |
| .github/workflows/test-download.yml | Comprehensive CI workflow to test download script functionality across platforms |
| .github/workflows/release.yml | Updated release workflow to use the new download script in installation instructions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
download.py
Outdated
| return [f"musllinux_1_2_{arch}"] | ||
|
|
||
| elif system == "windows": | ||
| if arch == "amd64" or arch == "x86_64": |
There was a problem hiding this comment.
The arch variable has already been normalized using arch_map, so checking for 'amd64' is redundant since it gets mapped to 'x86_64' on line 36.
Suggested change
| if arch == "amd64" or arch == "x86_64": | |
| if arch == "x86_64": |
.github/workflows/release.yml
Outdated
Comment on lines
486
to
490
| curl -sSL https://raw.githubusercontent.com/cpp-linter/clang-tools-wheel/feature/main/download.py | python3 - clang-format --version ${{ github.event.inputs.llvm_version }} | ||
| pip install clang-format-*.whl | ||
| # Install clang-tidy | ||
| pip install clang-tidy-${{ github.event.inputs.llvm_version }}-<platform>.whl | ||
| # Download and install clang-tidy | ||
| curl -sSL https://raw.githubusercontent.com/cpp-linter/clang-tools-wheel/feature/main/download.py | python3 - clang-tidy --version ${{ github.event.inputs.llvm_version }} |
There was a problem hiding this comment.
The URLs reference 'feature/main' which appears to be an incorrect branch name. This should likely be just 'main'.
.github/workflows/release.yml
Outdated
Comment on lines
486
to
490
| curl -sSL https://raw.githubusercontent.com/cpp-linter/clang-tools-wheel/feature/main/download.py | python3 - clang-format --version ${{ github.event.inputs.llvm_version }} | ||
| pip install clang-format-*.whl | ||
| # Install clang-tidy | ||
| pip install clang-tidy-${{ github.event.inputs.llvm_version }}-<platform>.whl | ||
| # Download and install clang-tidy | ||
| curl -sSL https://raw.githubusercontent.com/cpp-linter/clang-tools-wheel/feature/main/download.py | python3 - clang-tidy --version ${{ github.event.inputs.llvm_version }} |
There was a problem hiding this comment.
The URLs reference 'feature/main' which appears to be an incorrect branch name. This should likely be just 'main'.
Co-authored-by: Copilot <[email protected]>
shenxianpeng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.