adds support for federated terminology provider

[raleigh-g-thompson]

Still a WIP, working on tests

[github-actions]

Formatting check succeeded!

[c-schuler]

This is what I see implemented:

1. Infrastructure for federated routing - The FederatedTerminologyProviderRouter and related interfaces are in place
2. Client-level VSAC detection - VsacTerminologyServerClient.isCanonicalMatch() detects VSAC URLs via regex: https*://cts.nlm.nih.gov/fhir.*
3. Endpoint prioritization logic - prioritizeEndpoints() can sort endpoints by URL matching
4. Single terminologyEndpoint support - Works as before, one endpoint for all terminology

These are the gaps I see:

CRMI Requirement │ Current State
Parse artifactEndpointConfiguration │ Throws NotImplementedOperationException
Route based on artifactRoute │ Not implemented
Support multiple endpoints │ Router methods exist but aren't called
Priority by match length │ prioritizeEndpoints() uses boolean match, not character count

Do you agree with my assessment of what is implemented and the gaps with CRMI?

[codecov]

Codecov Report

❌ Patch coverage is 51.45631% with 150 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.55%. Comparing base (b83fd67) to head (b9aeb6e).

Files with missing lines	Patch %	Lines
...erminology/FederatedTerminologyProviderRouter.java	10.31%	112 Missing and 1 partial ⚠️
.../org/opencds/cqf/fhir/cr/visitor/ExpandHelper.java	50.00%	15 Missing and 1 partial ⚠️
...y/client/terminology/ITerminologyServerClient.java	78.57%	3 Missing and 3 partials ⚠️
...org/opencds/cqf/fhir/cr/visitor/VisitorHelper.java	84.00%	0 Missing and 4 partials ⚠️
...ent/terminology/ArtifactEndpointConfiguration.java	88.57%	2 Missing and 2 partials ⚠️
...nt/terminology/GenericTerminologyServerClient.java	66.66%	3 Missing ⚠️
...lient/terminology/VsacTerminologyServerClient.java	84.21%	2 Missing and 1 partial ⚠️
...rg/opencds/cqf/fhir/cr/visitor/ReleaseVisitor.java	88.88%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #905      +/-   ##
============================================
- Coverage     73.82%   73.55%   -0.28%     
  Complexity      364      364              
============================================
  Files           601      606       +5     
  Lines         29548    29758     +210     
  Branches       3923     3944      +21     
============================================
+ Hits          21815    21888      +73     
- Misses         5818     5946     +128     
- Partials       1915     1924       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[c-schuler]

Summary of updates:

1. Model Layer (cqf-fhir-utility)

ArtifactEndpointConfiguration.java - New class

• Holds artifactRoute, endpointUri, endpoint
• getMatchScore(canonicalUrl) - returns match length or -1 (no match) or 0 (fallback)
• getEffectiveEndpoint(FhirContext) - creates endpoint from either endpoint or endpointUri

2. Router Layer (cqf-fhir-utility)

ITerminologyProviderRouter.java - Added methods:

• expandWithConfigurations()
• getValueSetResourceWithConfigurations()
• getCodeSystemResourceWithConfigurations()

FederatedTerminologyProviderRouter.java - Implemented:

• prioritizeConfigurations() - CRMI ranking by match length, preserving input order for ties
• All new interface methods with fallback-on-failure logic

3. Visitor Layer (cqf-fhir-cr)

VisitorHelper.java - Added:

• getArtifactEndpointConfigurations() - parses nested parameter structure

ExpandHelper.java - Added:

• Overloaded expandValueSet() accepting List
• Tries CRMI routing first, falls back to legacy single endpoint

PackageVisitor.java - Updated:

• Parses artifactEndpointConfiguration from parameters
• Passes configurations through to handleValueSets() and expandValueSet()
• Removed the NotImplementedOperationException

[raleigh-g-thompson]

No changes recommended.

I can't approve though since I'm also one of the authors.

[sliver007]

The artifactEnpointConfiguration path should be aware of and respect the authoritativeSource extension - if an authoritativeSource is specified, it should be used in the comparison logic for endpoint resolution rather than the artifact's URL/canonical.

[brynrhodes]

I don't understand this bit, the client shouldn't be involved in the routing configuration.