Add LSP command for getting ELM JSON#65
Closed
mgramigna wants to merge 1 commit intocqframework:masterfrom
Closed
Conversation
Contributor
|
Issue resolved with PR #104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44
This PR adds support for a command that returns a JSON string of the ELM content (as opposed to XML). I tried to duplicate as little code as possible, but let me know if there is a more desirable approach for this.
The following is me executing both
org.opencds.cqf.cql.ls.viewElmJsonandorg.opencds.cqf.cql.ls.viewElmin neovim. If desired, I'm happy to make a companion contribution to https://github.com/cqframework/vscode-cql that adds viewing the JSON as an option in the extension menu.Screen.Recording.2023-04-03.at.3.15.15.PM.mov