fix: replace array_merge for upload#1723
Open
ishetnogferre wants to merge 1 commit intocraftcms:6.xfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When importing asset arrays where some assets already exist and others need to be uploaded, the use of
array_merge()operations destroys the relationship between array positions and their corresponding sub-field data. This causes alt text, custom fields, and other asset metadata to be applied to the wrong assets.Root Cause
The issue occurs in
Assets.php:parseField()where:$foundElements = array_merge($foundElements, $ids)destroys array position mappingpopulateFields()maps field data using array keys that no longer correspond to original positionsReplace
array_merge()operations with position-preserving array assignments:Key Changes
$foundElements = array_fill_keys(array_keys($value), null)$foundElements[$key] = $idinstead ofarray_merge()$foundElements[$uploadKey] = $uploadedElements[0]nullvalues, preserve indicesRelated issues
Fixes #1722